Giter Club home page Giter Club logo

Comments (7)

jamonholmgren avatar jamonholmgren commented on August 17, 2024

Just a guess, but does it change anything if you do this:

  def open_srm_analyzer_screen(args={})
      open SRMAnalyzerScreen.new(nav_bar: true), modal:true
  end

from promotion.

jamonholmgren avatar jamonholmgren commented on August 17, 2024

Also, what iOS target are you using?

from promotion.

markrickert avatar markrickert commented on August 17, 2024

Targeting iOS 5.0.

Sending the nav bar to the class instead of the attributes didn't change anything.

You can see the repository here: https://github.com/markrickert/BAStyleGuide/tree/srm-analyzer-experimental (note the branch) and specifically, the lines here:
https://github.com/markrickert/BAStyleGuide/blob/srm-analyzer-experimental/app/Screens/SRMAnalyzerScreen.rb#L129-L144
https://github.com/markrickert/BAStyleGuide/blob/srm-analyzer-experimental/app/Screens/StylesScreen.rb#L132-L138

I'm really wondering why those methods aren't getting called in my PM::Screen subclass at all...?

from promotion.

jamonholmgren avatar jamonholmgren commented on August 17, 2024

I've been buried today...I'll spin up an app and see if mine get called when I can.

from promotion.

markrickert avatar markrickert commented on August 17, 2024

Yeah, no worries. I'm not concerned about it too much at this point... It just has to be fixed before I ship the app.

One thing to note is that my version of ProMotion is vendored to a clone of the repos checked out on version-0.7 one level above the project. Feel free to modify the gemfile to suit your needs.

from promotion.

jamonholmgren avatar jamonholmgren commented on August 17, 2024

Version 0.7.2 fixes this.

from promotion.

markrickert avatar markrickert commented on August 17, 2024

👍

bundle update && rake clean && rake

it works!

...now I just have to figure out how to force it into displaying the modal in portrait mode when invoked from landscape 😢

Thanks for the fix!

from promotion.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.