Giter Club home page Giter Club logo

Comments (15)

JamieMason avatar JamieMason commented on May 24, 2024

Sorry for the delay getting to this, I've been really busy the last few weeks with my regular work.

I take it from your description that the CLI runs for quite a long time, chugging through all the files - then after quite some time falls over? Does it always fail at the end while it's writing out the summary of savings? or sometimes before then?

If the former, I wonder if the summary output is so large it occupies more memory than is available to the process. If the latter, I'll need to think about it some more :)

from grunt-imageoptim.

nwtn avatar nwtn commented on May 24, 2024

No need to apologize :)

The CLI does indeed run for a long time chugging through the files. Basically the CLI opens the ImageOptim GUI, which runs for ages while the CLI just idles. Then, once the GUI completes its optimizations, the CLI starts writing the summary. It's during this that it dies. So far it's never died before writing a big chunk of the summary -- as I said above, somewhere around 1000 files is typical.

Thanks!

from grunt-imageoptim.

JamieMason avatar JamieMason commented on May 24, 2024

Great, if it wasn't that I would have been short of ideas. I think the buffer of text being prepared for writing out to the terminal is so big that the process runs out of memory.

Thanks pal.

from grunt-imageoptim.

nwtn avatar nwtn commented on May 24, 2024

Ok cool. I'll try freeing up some memory and re-running to see if that helps.

from grunt-imageoptim.

JamieMason avatar JamieMason commented on May 24, 2024

I don't think that will help, I need to change the CLI.

from grunt-imageoptim.

curtisblackwell avatar curtisblackwell commented on May 24, 2024

I'm having the exact same thing happen as described by @nwtn here.

from grunt-imageoptim.

JamieMason avatar JamieMason commented on May 24, 2024

Thanks @curtisblackwell, @nwtn — I will address this soon.

from grunt-imageoptim.

schiggi avatar schiggi commented on May 24, 2024

Any update on this bug? Unfortunately, I've got the same problem and need to split my files in separate runs to have them optimised.

from grunt-imageoptim.

curtisblackwell avatar curtisblackwell commented on May 24, 2024

Is it possible this could be fixed by not outputting the savings for each file? A total or per-directory savings would be enough for me.

from grunt-imageoptim.

JamieMason avatar JamieMason commented on May 24, 2024

@curtisblackwell @schiggi @nwtn

Just a note to assure you I'm aware of the issue. The long delays are down to contract and freelance work (I'm even working at the moment) but I intend to write a fix as soon as I have enough time.

from grunt-imageoptim.

nwtn avatar nwtn commented on May 24, 2024

@JamieMason do you know what the cause of the problem is? I'm going to take a look at this this week and will submit a PR, but if you know where I should focus my attention, that would be super helpful.

from grunt-imageoptim.

nwtn avatar nwtn commented on May 24, 2024

Workaround posted in commits/PRs above. @JamieMason it would be awesome if you could take a look.

@curtisblackwell @schiggi @intellix hopefully this solves your problems too.

from grunt-imageoptim.

JamieMason avatar JamieMason commented on May 24, 2024

Hugely grateful for this @nwtn. I've been swamped with client work for quite some time but promise to pick this and other issues up asap. Thanks again for your help and patience.

from grunt-imageoptim.

nwtn avatar nwtn commented on May 24, 2024

@JamieMason no worries, I know how things can get :D

from grunt-imageoptim.

JamieMason avatar JamieMason commented on May 24, 2024

Sorry for the huge wait, I will close this and instead track ongoing issues over at https://github.com/JamieMason/ImageOptim-CLI/.

from grunt-imageoptim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.