Bug: realtime parser returns duplicate vehicles about gtfs HOT 3 CLOSED

Ahhhhh the root cause is pretty subtle. When we're parsing entities we de-duplicate vehicles using a map keyed on VehicleID whose current definition is:

type VehicleID struct {
	ID           *string
	Label        *string
	LicencePlate *string
}

The problem is that even if the values of the ID fields match after following the pointer, Go considers them distinct from a hashing perspective because the pointers themselves are different. I think the simplest solution would be to remove the pointers:

type VehicleID struct {
	ID           string
	Label        string
	LicencePlate string
}

and interpret a field being "" as equivalent to the field not being provided in the GTFS realtime feed. In theory the feed could have Label: &"" but I think this edge case is not a big deal.

from gtfs.

Started working on this in https://github.com/jamespfennell/gtfs/tree/duplicate-vehicles

from gtfs.

Great catch, thanks so much for fixing this!

from gtfs.