When() Fluent Restriction about coravel HOT 11 CLOSED

@papakaliati - create a new branch off the current master branch (a nice new clean one). You'll see that the scheduler is quite different now.

So, basically, add a new method to IScheduledEventConfiguration :

IScheduledEventConfiguration When(Func<Task> predicate);

Internally, the ScheduledEvent will implement this new method.

Just add one private field to hold Func<Task> (so only one predicate is ever used).

Put the check in InvokeScheduledEvent as the first thing. If When is not null, and it returns false, then return right away. Otherwise, keep going as normal.

Hopefully that make sense?

Thanks for the help!

from coravel.

Reporting for duty.

from coravel.

Hmm can't see you in the list. O well. I'll let you know when things are ready to go 👍

from coravel.

from coravel.

lol Ya, actually I meant Func<Task<bool>>.

So that call should be awaited when being checked in the ScheduledEvent .

Sorry about that!

from coravel.

from coravel.

from coravel.

I think just using Func<Task<bool>> is fine.

If there's a time when the user doesn't need to use an async method / await, they should be able to use return Task.FromResult(true);

So some good unit tests you could build are something like:

bool shouldRun = true;

scheduler
    .Schedule(someAction)
    .When(() => return Task.FromResult(shouldRun)); 

And maybe another one something like this:

Func<Task<bool>> shouldRun = () => Task.FromResult(true);

scheduler
    .Schedule(someAction)
    .When(shouldRun); 

And to include awaiting:

Func<Task<bool>> shouldRun = async () =>
{
     await Task.Delay(0);
     return true;
}

scheduler
    .Schedule(someAction)
    .When(shouldRun); 

And of course, some cases when "shouldRun" is false and make sure the task didn't run. Those are just off the top of my head... hopefully they ok lol.

Thanks @papakaliati !

from coravel.

from coravel.

Done at #32

from coravel.

Cheers mate, thanks 👍

from coravel.