Giter Club home page Giter Club logo

Comments (11)

JamesIves avatar JamesIves commented on May 8, 2024 1

This is now available in releases/v3 and versioned as 3.1.0. Thanks for reporting this!

https://github.com/JamesIves/github-pages-deploy-action/releases/tag/3.1.0

from github-pages-deploy-action.

JamesIves avatar JamesIves commented on May 8, 2024

I'm a little confused about why your workflow is failing as I don't have much insight into what those subsequent steps are doing.

The deployment action does create a temporary work space for a git command it runs which you can see here. Are you requesting that this temp folder gets deleted once the deployment has been completed?

If that's a suitable solution I'm happy to push up a test version for this today.

from github-pages-deploy-action.

brockfanning avatar brockfanning commented on May 8, 2024

Thanks for the quick reply @JamesIves. My only concern is the difference between the output under my "scripts folder before deploy" and "scripts folder after deploy". Do you know of any reason that this would happen? My goal is for this folder to be the same after the deploy as it was before. Hope that makes sense - sorry I'm not sure if this is related to the temp work space.

from github-pages-deploy-action.

JamesIves avatar JamesIves commented on May 8, 2024

I have a theory on this. I'm guessing because it checks out a temporary branch with just the deployment changes prior to pushing is why you're seeing such a large discrepancy here.

I think two things need to happen after the deployment is done.

  1. It switches back to the base branch (master if it's not specified)
  2. It needs to delete the temporary deployment folder which is created.

Can you run this workflow again using JamesIves/github-pages-deploy-action@releases/v3-test? I've pushed up a change which may fix this.

from github-pages-deploy-action.

brockfanning avatar brockfanning commented on May 8, 2024

Thanks again - unfortunately it doesn't look like it fixed it. Here is the latest output. To simplify things I removed the "cache" stuff. The contents of that folder still seems to be different before/after the deploy.

from github-pages-deploy-action.

brockfanning avatar brockfanning commented on May 8, 2024

Oh, I see that you said it switches back to the "base branch". Is that what I configured as BASE_BRANCH here? If so, that's not what I would prefer. It should go back to the branch that was checked out for the build. So, whatever got checked out during the "actions/checkout" branch.

from github-pages-deploy-action.

JamesIves avatar JamesIves commented on May 8, 2024

actions/checkout checks out the default branch of the repo. Do you know of a git command that switches you back to the default branch?

from github-pages-deploy-action.

brockfanning avatar brockfanning commented on May 8, 2024

From what I can tell here it depends on what event triggered the workflow. Maybe we could use $GITHUB_SHA here?

from github-pages-deploy-action.

JamesIves avatar JamesIves commented on May 8, 2024

@brockfanning Pushed up another update for this. Let me know if that works for you.

from github-pages-deploy-action.

brockfanning avatar brockfanning commented on May 8, 2024

Looks like that worked! The contents of that folder are the same now before and after the deploy (link to output). πŸ‘

from github-pages-deploy-action.

JamesIves avatar JamesIves commented on May 8, 2024

Perfect! Let me clean up this PR a little bit first and I'll cut a new release. I'll let you know when that's done so you can revert back to using releases/v3.

from github-pages-deploy-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.