Comments (3)
I committed a patch to workaround the problem, I don't have the toolchain to test, please check if it works.
from bustache.
Nice, one more thing:
in model.hpp
you seem to forward declare std::variant
. This causes the following issue:
In file included from /Users/minski/bustache/include/bustache/render.hpp:10:
/Users/minski/bustache/include/bustache/model.hpp:694:33: error: reference to 'variant' is ambiguous
struct impl_compatible<std::variant<T...>>
^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk/usr/include/c++/v1/variant:1261:28: note: candidate found by name lookup is 'std::__1::variant'
class _LIBCPP_TEMPLATE_VIS variant
^
/Users/minski/bustache/include/bustache/model.hpp:32:11: note: candidate found by name lookup is 'std::variant'
class variant;
^
/Users/minski/bustache/include/bustache/model.hpp:696:45: error: reference to 'variant' is ambiguous
static value_ptr get_value_ptr(std::variant<T...> const& self)
^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk/usr/include/c++/v1/variant:1261:28: note: candidate found by name lookup is 'std::__1::variant'
class _LIBCPP_TEMPLATE_VIS variant
^
/Users/minski/bustache/include/bustache/model.hpp:32:11: note: candidate found by name lookup is 'std::variant'
class variant;
^
2 errors generated.
Simply including <variant>
in model.hpp
fixes the issue for me:
#include <functional>
+#include <variant>
#ifdef BUSTACHE_USE_FMT
#include <fmt/format.h>
#elif defined(__cpp_lib_format)
@@ -26,11 +27,13 @@
#include <iterator>
#endif
+/*
namespace std
{
template<class... T>
class variant;
};
+*/
What do you think?
from bustache.
Because the use of std::variant is optional, I tried to avoid unnecessary include if the user doesn't use it.
But technically speaking, one should not forward declare standard types 😥.
What you proposed is absolutely right.
from bustache.
Related Issues (20)
- Compilation error with C++17 variant conflict
- Insert a template into another template? HOT 2
- `boost::unordered_map<>` vs `std::unordered_map<>` HOT 1
- Improve CMake package integration HOT 1
- Add line/column info to `format_error` HOT 2
- Bustache RVO HOT 1
- How to search Bustache Object for data? HOT 2
- Search Bustache Object for data - enhansement HOT 2
- thank you and may I have some more, please HOT 2
- Empty string on one case but not a similar other one HOT 1
- Is interface for Bustache C++20 incomplete? HOT 10
- Bustache compiles fine using nlohmann::json but not with nlohmann::ordered_json containers HOT 2
- Is it possible to execute a function when a specific replacement tag is rendered? HOT 1
- Bustache data adapter for Nlohmann Json? HOT 2
- New kid on the block HOT 4
- Examples using headers from test HOT 1
- Compiling Error HOT 1
- Trouble getting Partials (embedded templates) working when using the Nlohmann Json adapter. HOT 5
- Will latest versions of Bustache compile on gcc 7.4? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bustache.