Giter Club home page Giter Club logo

Comments (3)

jamalsenouci avatar jamalsenouci commented on June 24, 2024 2

Hi,

Thanks for investigating this. You're right about changing the iloc to loc. Initial thoughts are that the results are pretty similar in the point predictions but the python version has wider confidence intervals. It's worth noting they are using different estimation methods so I wouldn't expect them to give identical results at the moment. I'm not sure what's going on with the x-axis markers on the plot either, I might raise a different issue for that

from causalimpact.

WillFuks avatar WillFuks commented on June 24, 2024

Hi @jamalsenouci , first of all, thank you for this python implementation of CI!

I've been trying to understand why the credible intervals for the python implementation using MLE is wider than from Google's MCMC but couldn't figure this out yet. Do you know why this happens?

As far as theory goes I can't understand why they would lead to such different results, still I imagine that MLE should lead to more precise results given its closed solution.

In Google's code there's this upper boundary asserted to the standard deviation of the level, could this explain the difference? Maybe the markovian sampling is not allowed to go further than the standard deviation of the input data which works as a cap for the ci given y can't vary more than 1 sdy.

Couldn't find in the paper an explanation for that as well.

from causalimpact.

jamalsenouci avatar jamalsenouci commented on June 24, 2024

closing in favour of #42

from causalimpact.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.