Comments (3)
Hi,
Thanks for investigating this. You're right about changing the iloc to loc. Initial thoughts are that the results are pretty similar in the point predictions but the python version has wider confidence intervals. It's worth noting they are using different estimation methods so I wouldn't expect them to give identical results at the moment. I'm not sure what's going on with the x-axis markers on the plot either, I might raise a different issue for that
from causalimpact.
Hi @jamalsenouci , first of all, thank you for this python implementation of CI!
I've been trying to understand why the credible intervals for the python implementation using MLE is wider than from Google's MCMC but couldn't figure this out yet. Do you know why this happens?
As far as theory goes I can't understand why they would lead to such different results, still I imagine that MLE should lead to more precise results given its closed solution.
In Google's code there's this upper boundary asserted to the standard deviation of the level, could this explain the difference? Maybe the markovian sampling is not allowed to go further than the standard deviation of the input data which works as a cap for the ci given y
can't vary more than 1 sdy
.
Couldn't find in the paper an explanation for that as well.
from causalimpact.
closing in favour of #42
from causalimpact.
Related Issues (20)
- support bayesian estimation methods HOT 3
- does not work with latest version of pandas HOT 1
- How to get P-value in Python version? HOT 7
- Key Error: 'upper y' HOT 41
- CSV Data? HOT 3
- compile_posterior_inferences() missing 1 required positional argument: 'estimation' HOT 4
- ValueError: The truth value of a Series is ambiguous. Use a.empty, a.bool(), a.item(), a.any() or a.all(). HOT 1
- Apache License? HOT 1
- Think p-value was not calculated properly
- AttributeError: 'CausalImpact' object has no attribute 'inferences' HOT 3
- Binder fails to build HOT 1
- Coverage file is not being created in gh action HOT 1
- Confidence intervals wider than R version
- TypeError: is_list_like() takes 1 positional argument but 2 were given
- Validation and comparison against the R package
- Confidence Interval First Data Point HOT 1
- Causal Impact failing due to to pandas update HOT 2
- Calculation error of p-value HOT 4
- x axis is displaying incorrectly when modelling series with datetime index HOT 1
- compile_posterior_inferences throws error on integer referencing with a datetime value
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from causalimpact.