Giter Club home page Giter Club logo

Comments (14)

magro avatar magro commented on August 23, 2024

Btw, I just extracted the UserService.Service to its own file and this seems to fixes it. At least with my fork of securesocial I can run my application tests now with this change.

from securesocial.

magro avatar magro commented on August 23, 2024

I know this is a bigger change, as it affects users that are already using securesocial with the UsernamePasswordProvider, but it would be great to have this in the next release (assuming that you can confirm the issue and solution).

from securesocial.

jaliss avatar jaliss commented on August 23, 2024

Martin, thanks for the report and suggested fix. Will try to figure out what's causing the problem. Give me some time as I am really busy trying to meet a deadline on project.

from securesocial.

jaliss avatar jaliss commented on August 23, 2024

This looks like a problem in the Enhancer rather than in SecureSocial itself. It looks like it is getting confused by the inner class.

from securesocial.

magro avatar magro commented on August 23, 2024

Yes, I agree. But chances that it's fixed and the fix/workaround is released in the not-too-far-future is bigger here than with play core ;-)

from securesocial.

timrwilliams avatar timrwilliams commented on August 23, 2024

This issue also caught me in my CI build but i've taken a slightly different approach to solve. In my fork I've added the ability to specify the UserService class as a property, this is then instantiated via Reflection rather than searching classpath.

The property is optional so would be backward compatible with all current users. I don't have any preference for this over the already discussed solution here but just raising it for reference.

https://github.com/timrwilliams/securesocial/blob/master/app/securesocial/plugin/SecureSocialPlugin.java

from securesocial.

jaliss avatar jaliss commented on August 23, 2024

Has anyone tried taking the inner class out and putting it in its own file?

from securesocial.

bnahas avatar bnahas commented on August 23, 2024

Jorge, I just broke the inner class out into its own file and that fixed the problem for me. Magro mentioned earlier in this thread that he did the same thing.

from securesocial.

jaliss avatar jaliss commented on August 23, 2024

Ah sorry. Replied without reviewing the whole thread. We can either take it out of take @timrwilliams approach. Will test with the latest Play 1 version.

from securesocial.

spinscale avatar spinscale commented on August 23, 2024

Hey, I also just stumbled over this bug with play 1.2.4 and 1.2.5-rc4... any updates here?

from securesocial.

jaliss avatar jaliss commented on August 23, 2024

This should not happen anymore thanks to @magro's pull request.

from securesocial.

magro avatar magro commented on August 23, 2024

Great! Are you going to make a new release?

from securesocial.

jaliss avatar jaliss commented on August 23, 2024

Yes, I tried to do it yesterday but bumped into a problem with the modules page. I sent an email asking. Once that is solved I'll publish it.

Did you see my note about renaming the interface?

from securesocial.

magro avatar magro commented on August 23, 2024

Great, thanx! Yes, I saw your note regarding the renaming, fine.

from securesocial.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.