ThrowableNotAtBeginning doesn't seem to run, TimberArgCount catches first. about timber HOT 5 OPEN

Actually I don't know why this doesn't trigger. It runs first...

from timber.

Currently, both TimberArgCount and ThrowableNotAtBeginning are thrown for this example.

Do we still want to remove TimberArgCount here and behave like String.format(...) (which ignores extra arguments)?

from timber.

I still want to fail on extra arguments. Maybe ignore a single extra argument if its type is a subclass of Throwable and it's last?

I'm fine with both being triggered, but I'd prefer not to send mixed messages.

from timber.

Maybe ignore a single extra argument if its type is a subclass of Throwable and it's last?

Here's how that would look:

Timber.d("Failed", e);                    // fail: ThrowableNotAtBeginning
Timber.d("Failed %s", "s", e);            // fail: ThrowableNotAtBeginning
Timber.d("Failed %s", e, "s");            // fail: ThrowableNotAtBeginning AND TimberArgCount
Timber.d("Failed %s %s", e, "s1", "s2");  // fail: ThrowableNotAtBeginning AND TimberArgCount
Timber.d("Failed %s %s", "s1", e, "s2");  // fail: ThrowableNotAtBeginning AND TimberArgCount
Timber.d("Failed %s %s", "s1", "s2", e);  // fail: ThrowableNotAtBeginning

Adding the last argument constraint might be confusing. WDYT?

from timber.

The reasons the check exists is because Android's Log accepts the throwable at the end instead of the start. In your examples I would think that only TimberArgCount would run for the three examples where both are currently running.

from timber.