Giter Club home page Giter Club logo

Comments (8)

TanjaObradovic avatar TanjaObradovic commented on June 10, 2024 1

Ok - looks good to me! I thought this was previously implemented and live already - @ivargrimstad Ivar know me the best :)
Sorry for the hold up! Thanks @oliviergoulet5 for your patience!

from jakarta.ee.

oliviergoulet5 avatar oliviergoulet5 commented on June 10, 2024

The problem was that the sorting was happening on a character-by-character basis. The first character of 11 is 1, which comes before 8 alphanumerically.

@TanjaObradovic I fixed the sorting on all specification pages to treat numbers as proper numbers.

Here is a preview of a few specification pages which had this issue:

from jakarta.ee.

shabnammayel avatar shabnammayel commented on June 10, 2024

LGTM! @TanjaObradovic are you good with the changes too?

from jakarta.ee.

TanjaObradovic avatar TanjaObradovic commented on June 10, 2024

For these three it looks good, however for individual specifications does not - it is in revers order
image

from jakarta.ee.

oliviergoulet5 avatar oliviergoulet5 commented on June 10, 2024

@TanjaObradovic I don't see that ordering on the preview site. The previews show the versions in descending order for every specification:

image

from jakarta.ee.

TanjaObradovic avatar TanjaObradovic commented on June 10, 2024

Hmmmm strange!
@shabnammayel what do you see?
here is for Activation in in another browser
image

from jakarta.ee.

ivargrimstad avatar ivargrimstad commented on June 10, 2024

@TanjaObradovic as @oliviergoulet5 points out, you need to see it in the preview. If you click between the sessions you end up on the real site. Try this one:

https://deploy-preview-1819--jakartaee.netlify.app/specifications/activation/

(note that the root URL is NOT jakarta.ee)

from jakarta.ee.

shabnammayel avatar shabnammayel commented on June 10, 2024

Yes, they look good to me as well!

from jakarta.ee.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.