Comments (6)
Here are some thoughts:
- I don't like having to push a sigma version to fix a node-image-program bug
- I would like more features to be hosted on this repository, such as curved edges for instance
- I wouldn't want these new features to be packaged with sigma
So, I'm sure it would be better to split like you say. I agree with having a sigma
package that is more plug-and-play (though I think I would like to move node-image-program outside of it). For the rest, @sigma/core
makes sense to me, @sigma/node-image-program
as well (and hopefully @sigma/edge-curved-program
sometime). For @sigma/default-programs
I don't know I prefer this or @sigma/node-circle-program
, @sigma/edge-arrow-program
, etc...
Another aspect to consider is how we want the repository to be organized. The current src
files structure is kinda weird (having programs altogether in a folder, then all shaders in another one, rather than having one directory per program).
from sigma.js.
My points, in "vrac" (I did not re-read the whole discussion so they might be moot or redundant):
- We should keep a monorepo structure for stuff that need to benefit from functional testing, so we don't duplicate the complicated stack it requires. I don't know what's the go-to utility to deal with monorepo easily these days. I tend to somewhat use
lerna
but I think it is not maintained anymore. - The
sigma
package should remain the main installation target, for convenience and backwards-compat (v3 is mostly aligned with v2 if you don't develop custom rendering anyway). It can be a compilation of other subpackages indeed. I don't really see the value in "over" splitting the core of the library into a core, renderers, camera etc. since we don't envision supporting something else than an interactive webgl renderer. - I agree that the
@sigma
scope vs.sigma-
prefixed packages means we can control the scope against potential squatting (the expression is a bit harsh lol)
from sigma.js.
OK, so here is a plan:
- Split codebase into a multi-packages repository (something similar to what @sim51 did in react-sigma, with
sigma
,examples
,demo
andwebsite
- Move
edge.triangle
into thecustom-rendering
example (I'm sure nobody uses it, partly because without anti-aliasing it makes things awful to read) - Move
node.image
as a newnode-image-renderer
package (still in the same repo) - Update documentation about how to release etc..
Then, the packages we would have would be:
sigma
(same as today, but withoutedge.triangle
andnode.image
@sigma/node-image-renderer
, with the current version of the factory (then we should add proper testing, and port some of @Yomguithereal's take on it)
And for later, we could add @sigma/edge-curve-renderer
and @sigma/image-export
for instance.
from sigma.js.
WIP on branch v3-packages
- Demo has been migrated to latest version of react-sigma, but it remains the label renderer and the graph button style
- Example : example that need a custom program or a hover/label render need some modifications
from sigma.js.
- Redo label renderer on demo
- Review README
- Review examples with custom program
- Review examples with node hover/label render
from sigma.js.
I close this ticket since it's mostly done, and the remaining tasks haven't been discussed here yet.
from sigma.js.
Related Issues (20)
- Node scaling issue on MacOS with NodeBorderProgram and NodePointProgram HOT 8
- NodeCircleProgram is buggy on Chrome mobile
- @sigma/edge-curve is buggy on Chrome mobile
- How do I do custom shapes? HOT 1
- Create a snapshot of "sigma-containter" HOT 1
- Questions about the use of the sigma HOT 1
- The error of edge reduce HOT 3
- Optimizing Zoom Functionality for Scalable Graphics HOT 3
- CDN release for latest version HOT 4
- Sigma with VueJs HOT 2
- Utility functions not available when loading sigma statically via cdn HOT 1
- Add Kenelyze to the In The Wild section
- Changing programs with `setSetting` has no effect HOT 4
- Height and width for images in nodes HOT 2
- Angular: update from 2.4 to sigma 3.0 beta, cannot find type declarations error during compile HOT 4
- Opacity for edges HOT 7
- Combined (border+image) Program Node Rendering Issue HOT 3
- Can't set Edge Size Smaller than 1 in 2.4.0 HOT 2
- How to render self-loops?
- Issue with atlas generation in @sigma/node-image HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sigma.js.