D1_ERROR: near "-": syntax error at offset 30 about d1-manager HOT 8 CLOSED

I have multiple databases with hyphens in the name and the other ones work fine. So it's probably the hyphen in the table name.

from d1-manager.

I am not sure...

Is there any special character in the table name or column name? I may have forgotten to escape something...

from d1-manager.

The database is called prod-logs, the table logs-v1.
Here's the schema:

import { integer, sqliteTable, text } from "drizzle-orm/sqlite-core";

export const logsTableV1 = sqliteTable("logs-v1", {
    id: integer("id", { mode: "number" }).primaryKey({ autoIncrement: true }),

    // Timestamp
    timestamp: integer("timestamp", { mode: "number" }).notNull(),

    // Request details
    method: text("method").notNull(),
    url: text("url").notNull(),
    statusCode: integer("statusCode").notNull(),
    duration: integer("duration").notNull(),

    // Location details
    ip: text("ip").notNull(),
    country: text("country"),
    regionCode: text("regionCode"),
    city: text("city"),

    // Service details
    microservice: text("microservice").notNull(),
    deployment: text("deployment").notNull(),
    environment: text("environment").notNull(),

    // User details
    customerSessionId: text("customerSessionId"),
    userId: text("userId"),
    superadminId: text("superadminId"),

    // Additional data
    data: text("data"),

    // Error details
    error: text("error"),
});

Maybe timestamp is a problem?

from d1-manager.

I'm guessing it's the hyphen in the database name

from d1-manager.

https://stackoverflow.com/a/3694305/311220

A table name with a hyphen would need to be quoted.

Definitely some places where it looks like that's not happening:
https://github.com/search?q=repo:JacobLinCool/d1-manager+prepare+table&type=code

from d1-manager.

Hi @JacobLinCool
Thank you for this great tool,
It seems that Cloudflare takes the table name directly from the URL param without adding anything to it.
By simply adding single quotes to the table name in the URL it will solve the issue e.g. /api/db/demodb/'table-name'/data?...
I have also tested the case with database names with hyphen and it seems that Cloudflare accept using hyphens in database names, but unlike table names it is processed from Cloudflare side and quoting the database name in URLs isn't necessary.
I have also tested columns and it has the same issue as with table names, I will make a PR with suggested fix for both table and column names.

from d1-manager.

Hello @moalamri

Thank you for your observations and contributions on PR #53.

I want to clarify that the /api/... endpoints are not part of the Cloudflare API; they are located here.

Since the database name is not presented in the SQL statement, it seems I forgot to escape the table name in the following places:

Maybe your utility functions should be applied to those places instead of replacing them in the URL at the frontend side. (It seems strange to see quotes in an URL)

from d1-manager.

Hey @JacobLinCool
My bad :) I looked into the component and really assumed they were calling Cloudflare.
I will work on it soon, maybe simplify it more by always applying escape to identifiers since they can accept a lot of special characters.

from d1-manager.