completion/selection via ivy about dumb-jump HOT 8 CLOSED

Does that sound correct @abo-abo?

Yes, sounds fine. Here's an example of ivy-read use:

(defun test ()
  (interactive)
  (ivy-read "test: "
            '(("abc (1.txt)" "~/1.txt" 123)
              ("def (2.txt)" "~/2.txt" 1124))
            :action (lambda (x)
                      (message
                       "open file %s and goto-char %d"
                       (nth 1 x) (nth 2 x)))))

from dumb-jump.

+1 for this feature ❤️

from dumb-jump.

@wbolster @zilongshanren This is working now, but may take a bit before MELPA picks it up. All you need to do is already have ivy installed and add (setq dumb-jump-selector 'ivy) to your config.

from dumb-jump.

It's on MELPA now. Please let me know if you have any issues. Thanks!

from dumb-jump.

@wbolster Thanks for creating this issue. I am certainly open to supporting other selectors beyond just the pop-up.

As far as I can tell I can just use ivy-read. So I'll probably make a defcustom of like dumb-jump-selector that defaults to popup but can be ivy (and possibly other things too). Does that sound correct @abo-abo?

Thanks guys!

from dumb-jump.

awesome. ivy all teh things!!1

but this won't behave as a ag/grep style buffer, right? (on the fly visiting with C-l and so on.)

from dumb-jump.

but this won't behave as a ag/grep style buffer, right? (on the fly visiting with C-l and so on.)

It can behave as ag/grep, in fact like counsel-ag or counsel-grep. C-M-n and C-l work for these two and are easy to implement.

from dumb-jump.

great work, thanks a lot

from dumb-jump.