Comments (1)
Jacajack
commented on June 15, 2024
1
Thanks for pointing that out!
Apart from generating warning (which surprisingly isn't generated by my compiler) that's a pretty serious issue, that hasn't been caught before due to lack of tests for that code fragment.
I think that this is what I've meant:
//Check if frame length is valid
if ( status->request.length >= 7u )
{
frameLength = 9 + parser->request16.length;
if ( status->request.length != frameLength )
{
if ( parser->base.address != 0 ) return modbusBuildException( status, 16, MODBUS_EXCEP_ILLEGAL_VAL );
return MODBUS_ERROR_OK;
}
}from liblightmodbus.
Related Issues (20)
- Wrong ifdef for function 16 HOT 1
- How to use liblightmodbus with STM32? HOT 4
- Getting segmentation fault when using statically alllocated buffers HOT 3
- modbusParseRequest slave behavior HOT 1
- status->registerCallback uses MODBUS_REGQ_R_CHECK where MODBUS_REGQ_W_CHECK should be used HOT 1
- Adding build support for ESP-IDF HOT 5
- Plans for v3.0 - discussion HOT 16
- inttypes.h not available for xc16 compiler HOT 1
- is there any template/port file for mcu UART? HOT 3
- For loop initial declarations are incompatible with XC16 HOT 4
- Advise to implement function 21 (0x15) Write File Record HOT 2
- Example form TCP master integration HOT 3
- Wide data types support / TCP usage example HOT 4
- Can you help in porting for pic 18f6722 controller HOT 1
- Is MODBUS_REGQ_X_CHECK specified or designed? HOT 1
- Compilation in VS2022 HOT 12
- Modbus use for AVR HOT 1
- modbusMasterInit() and LPC1768 HOT 6
- CI updates & maintenance
- Handle invalid length of frame on slave mode HOT 15
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from liblightmodbus.