Memory access problem in rtpsources.cpp line 339 about jrtplib HOT 4 CLOSED

Hi Lau,

You're correct, this is indeed a problem.

I think the easiest fix would be to cache the CSRCs temporarily, before the srcdat->ProcessRTPPacket function is called, and then use those cached values further on (instead of obtaining them from rtppack)

This is what I tried to do in branch 'csrccache' - I haven't tested it though. Could you check if this works for you?

Thanks!
Jori

from jrtplib.

Hi Jori

That seems to have fixed the problem when running example 6 with valgrind.

I will do some more testing with my own project today and let you know.

Edit: One thing - if the number of received CSRC's exceed RTP_MAXCSRCS there may be a problem. Perhaps unlikely, but possible. The RTPPacket::ParseRawPacket does not limit the RTPPacket::numcsrcs to RTP_MACCSRCS.

Thank you for the fast response.

Lau

from jrtplib.

Hi Jori

I have not found any issues with your fix in the csrccache branch except for the potential problem I mentioned above.

Regards
Lau

from jrtplib.

Hi Lau,

The number of CSRCs comes from four bits in the RTP header, so it shouldn't exceed that maximum number. But it's probably best to be extra cautious, so I've added an extra check.

Thanks for testing!

Cheers,
Jori

from jrtplib.