Comments (7)
- modify the
Data
class- probably still makes sense to be a singleton
- watch out for performance, since we loop over the data a lot, what is the fastest way to store it?
- ideally, the user should not need to worry about instrument names
- ideally, input file should have a fourth column specifying the instrument
- as an integer? a string? can we make it as general as possible?
- add between-instrument offsets as parameters
- add jitter parameters for each instrument (?)
- GP hyperparameters should be common to all instruments
from kima.
from kima.
Working on this in the multi_instrument
branch
from kima.
The Data
class has two new load_multi
methods, overloaded to deal with either:
- one input file with a 4th column specifying the instrument (as an integer)
- multiple input files, one per instrument, each with the 3 usual columns
from kima.
- automatically add
number_instruments - 1
offset parameters - same prior for all offsets,
offsets_prior
- the user can change it
- by default is set to
Uniform(-10, 10)
(which doesn't make sense...) - best is probably to set it to
Uniform( - data.get_RV_span(), data.get_RV_span() )
- the
plot_random_planets
function now deals with the offsets, sokima-showresults rv/6
should work - it worked once, might break every other time...
from kima.
I think this is ready in the multi_instrument
branch. Going to merge it now into master.
from kima.
Done, closing this issue.
from kima.
Related Issues (20)
- Uncertainties in the indicators HOT 1
- Plotting GPRN fits HOT 1
- std::domain_error HOT 1
- Period aliases HOT 1
- quadratic (and cubic?) trend HOT 3
- Student-t likelihood HOT 1
- Custom mixture prior for orbital period
- 0 in fourth column HOT 1
- Discontinue obs_after_HARPS_fibers
- make src/RVmodel HOT 2
- Can we show the logo on the notification?
- phase_plot ignores known object? HOT 1
- Precompiled headers
- move things around
- Parametrizations
- [bug] kima-showresults fails when using the "phase" option HOT 1
- Missing prior distributions in pykima
- kima-showresults error after pip install
- migrating to version 5 HOT 1
- Request to set a prior on Tc for a known monotransit planet of unknown period HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kima.