Giter Club home page Giter Club logo

Comments (7)

j-faria avatar j-faria commented on June 16, 2024
  • modify the Data class
    • probably still makes sense to be a singleton
    • watch out for performance, since we loop over the data a lot, what is the fastest way to store it?
    • ideally, the user should not need to worry about instrument names
    • ideally, input file should have a fourth column specifying the instrument
      • as an integer? a string? can we make it as general as possible?
  • add between-instrument offsets as parameters
  • add jitter parameters for each instrument (?)
    • GP hyperparameters should be common to all instruments

from kima.

eggplantbren avatar eggplantbren commented on June 16, 2024

from kima.

j-faria avatar j-faria commented on June 16, 2024

Working on this in the multi_instrument branch

from kima.

j-faria avatar j-faria commented on June 16, 2024

The Data class has two new load_multi methods, overloaded to deal with either:

  • one input file with a 4th column specifying the instrument (as an integer)
  • multiple input files, one per instrument, each with the 3 usual columns

from kima.

j-faria avatar j-faria commented on June 16, 2024
  • automatically add number_instruments - 1 offset parameters
  • same prior for all offsets, offsets_prior
  • the user can change it
  • by default is set to Uniform(-10, 10) (which doesn't make sense...)
  • best is probably to set it to Uniform( - data.get_RV_span(), data.get_RV_span() )
  • the plot_random_planets function now deals with the offsets, so kima-showresults rv/6 should work
  • it worked once, might break every other time...

from kima.

j-faria avatar j-faria commented on June 16, 2024

I think this is ready in the multi_instrument branch. Going to merge it now into master.

from kima.

j-faria avatar j-faria commented on June 16, 2024

Done, closing this issue.

from kima.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.