Giter Club home page Giter Club logo

Comments (6)

iway1 avatar iway1 commented on August 16, 2024 1

Going to close for now because there are no current plans to support this. I think long term we want to get off of RHF to reduce bundle size which would allow doing super refine.

To achieve the same behavior in with this library, you'll need to do server validation outside of zod and react-ts-form.

from react-ts-form.

iway1 avatar iway1 commented on August 16, 2024

Is there something library isn't doing that you want it to do? this seems like a linting issue with zod itself?

from react-ts-form.

christopher-kapic avatar christopher-kapic commented on August 16, 2024

I opened an issue with Zod asking them to allow async methods and got the response that I should use parseAsync.

from react-ts-form.

iway1 avatar iway1 commented on August 16, 2024

ah okay well we don't even call parse or parseAsync in the library at the moment, react-hook-form's zod resolver is what calls it. Not sure if we can implement this since we're relying on RHF for this part? they might be able to fix it in the zod resolver package which would fix it for this lib

from react-ts-form.

christopher-kapic avatar christopher-kapic commented on August 16, 2024

I think we could pass an option to the zodResolver since react-hook-form checks for async here. I can work on this later today.

from react-ts-form.

iway1 avatar iway1 commented on August 16, 2024

@christopher-kapic oh nice didn't know that, that shouldn't be to bad to add in.

I guess it's currently indirectly supported if you pass in a form prop (since you can pass your own resolver there) - but might be nice to just have a zodResolverOptions prop or something on the Form component to make that customizable.

TBH I'm a little wary of this with how the zod resolver is working currently in the library, it's getting called twice because of some workaround I had to implement to get react-hook-form to work nicely. So the parse would get called twice with the current code which isn't a big deal normally but when there's an API request involved it's probably a bigger issue...

Really want to get that fixed but IDK if it's possible as long as we're using RHF

from react-ts-form.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.