Giter Club home page Giter Club logo

Comments (9)

florian-lefebvre avatar florian-lefebvre commented on August 16, 2024 2

It could be useful to make it configurable in the options of createTsForm https://github.com/iway1/react-ts-form/blob/main/src/createSchemaForm.tsx#L163

from react-ts-form.

florian-lefebvre avatar florian-lefebvre commented on August 16, 2024 1

LGTM

from react-ts-form.

stoickeyboard avatar stoickeyboard commented on August 16, 2024 1

I ran into this problem as well

from react-ts-form.

florian-lefebvre avatar florian-lefebvre commented on August 16, 2024 1

Yeah sounds great! And to prevent errors we could do

const [label, ...rest] = describe.split(' // ')
const placeholder = rest.join(' // ')

from react-ts-form.

iway1 avatar iway1 commented on August 16, 2024

Hmm good point, yeah right now it just looks for // so would need to change it.

Wondering what a good symbol would be that would be less likely to have conflicts

from react-ts-form.

iway1 avatar iway1 commented on August 16, 2024

yeah good idea that way it wouldn't be a breaking change too

from react-ts-form.

florian-lefebvre avatar florian-lefebvre commented on August 16, 2024

But I think changing the default one would be useful, urls are often used as placeholder

from react-ts-form.

iway1 avatar iway1 commented on August 16, 2024

good point, we'll change the default. What about -- as the separator? Seems pretty unlikely to have conflicts

gonna have to be in v2 since it's breaking though

from react-ts-form.

lucasjungdeveloper avatar lucasjungdeveloper commented on August 16, 2024

I think the default could stay as it is if it checks for ' // ' instead of '//'
Since in the URL it won't be surrounded by spaces
And by doing so it woudn't be a breaking change

from react-ts-form.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.