Add Random Sampling to PyTorch Frontend about ivy HOT 8 OPEN

There's no place where a default seed value is stored in ivy. So can you please add the default seed value for ivy and then we can use the same for torch frontend

from ivy.

There's no place where a default seed value is stored in ivy. So can you please add the default seed value for ivy and then we can use the same for torch frontend

Hi @vishwajit-vishnu, I don't think we are able to add support for this currently. First we will need to implement an ivy Generator class, which is on our roadmap.

from ivy.

Hi @AnnaTz, for this task, is both initial_seed and get_rng_state related to the generator class?
I was thinking to have a global variable for seed here at this file: https://github.com/unifyai/ivy/blob/0d9e03bad71aa6aa2b61118c6e5b6bfff3a51fea/ivy/functional/ivy/random.py and return it, would this work or should we wait till you have the generator class implemented?

from ivy.

Hi @AnnaTz, for this task, is both initial_seed and get_rng_state related to the generator class? I was thinking to have a global variable for seed here at this file: https://github.com/unifyai/ivy/blob/0d9e03bad71aa6aa2b61118c6e5b6bfff3a51fea/ivy/functional/ivy/random.py and return it, would this work or should we wait till you have the generator class implemented?

Hi @a0m0rajab, it wouldn't be enough to create a global variable for a seed. Instead we need to implement an ivy generator class and then a torch frontend generator class that will inherit from the ivy one. There are people in our team already looking into that. I would suggest you pick another ToDo list to contribute to.

from ivy.

Thank you for this information! @AnnaTz

from ivy.

@AnnaTz side note, would be adding toDo_internal label to this and removing the toDo label be okay? Since it seems to miss only those two functions and the others have a PR opened for it. I just get curious about this labels 😄

from ivy.

@AnnaTz side note, would be adding toDo_internal label to this and removing the toDo label be okay? Since it seems to miss only those two functions and the others have a PR opened for it. I just get curious about this labels 😄

Good idea 😅

from ivy.

Thank you for that!

from ivy.