Giter Club home page Giter Club logo

Comments (3)

jtrussell avatar jtrussell commented on July 30, 2024

Interesting. We were planning to rename the click handler to "toggle-callback" or some such (#45). So I think it might make sense to leave the callback invocation code there rather than split it out. I could get behind adding a way to stop clicks on labels from toggling the node though. It probably ought to be something similar to how checkboxes are enabled/disabled so that folks who make their own custom templates can honor that setting if need be. Exposed by the ivhTreeview controller and handled in the node template. Seem reasonable?

from angular-ivh-treeview.

jtrussell avatar jtrussell commented on July 30, 2024

In the v1 (hopefully soon to be merged in) "click" is renamed to toggle as mentioned above.

Since the label click behavior is fairly specific that may be better left for custom templates to sort out. Open to other opinions though.

from angular-ivh-treeview.

AbhishekGarg avatar AbhishekGarg commented on July 30, 2024

Hi @jtrussell ,
Custom templates is a great option. Though, I believe it results in lot of "template redundancy" in case it has to be applied in multiple places, nodeTpl definitely helps here.

Since ivhtreeview is so much configurable, a handler for label click would be great. I found it easy to implement, basis the older click handler (renamed to toggle).

I would be willing to submit a PR if you are still interested in this.

from angular-ivh-treeview.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.