Giter Club home page Giter Club logo

Comments (5)

Samueru-sama avatar Samueru-sama commented on July 30, 2024 1

HI I just made the PR adding the the application to the internal database of am.

Once merged you will be able to install the application with am -i music-assistant-companion or appman -i music-assistant-companion if you would like to have the appimage in your home dir.

Btw during testing I noticed that I had a broken .desktop file, that's because the appimage has a broken link for .desktop inside of it, I will report this later to the music assistant folks, I worked around the issue in the installation script anyway.

edit: done

from am.

ivan-hc avatar ivan-hc commented on July 30, 2024 1

just added #797 thanks @Samueru-sama

from am.

ivan-hc avatar ivan-hc commented on July 30, 2024

in the meantime I've found that the issue is this function

			if curl --output /dev/null --silent --head --fail "$API_GITHUB_REPO" | sed 's/[()",{} ]/\n/g' | grep -oi "https.*mage$" | grep -i "x86_64" | head -1 1>/dev/null; then
				FILTER=' | grep -i "x86_64" '
			elif curl --output /dev/null --silent --head --fail "$API_GITHUB_REPO" | sed 's/[()",{} ]/\n/g' | grep -oi "https.*mage$" | grep -i "x64" | head -1 1>/dev/null; then
				FILTER=' | grep -i "x64" '
			elif curl --output /dev/null --silent --head --fail "$API_GITHUB_REPO" | sed 's/[()",{} ]/\n/g' | grep -oi "https.*mage$" | grep -i "amd64" | head -1 1>/dev/null; then
				FILTER=' | grep -i "amd64" '
			else
				FILTER=' | grep -vi "i386\\|i686\\|aarch64\\|arm64\\|armv7l"'
			fi

this shoult detect "amd64" as an alternative in case the keyword "x86_64" does not exists

I need to fix this

from am.

ivan-hc avatar ivan-hc commented on July 30, 2024

grep -e seems to be the solution

from am.

ivan-hc avatar ivan-hc commented on July 30, 2024

Solved, now the function is smaller

		if [ "$arch" == "x86_64" ]; then
			if curl --output /dev/null --silent --head --fail "$API_GITHUB_REPO" | sed 's/[()",{} ]/\n/g' | grep -oi "https.*mage$" | grep -ie "x86_64\|x64\|amd64" | head -1 1>/dev/null; then
				FILTER=' | grep -ie "x86_64\\|x64\\|amd64" '
			else
				FILTER=' | grep -vi "i386\\|i686\\|aarch64\\|arm64\\|armv7l"'
			fi
		elif [ "$arch" == "i686" ]; then
			FILTER=' | grep -ie "i386\\|i686\\|i586\\|i486" '
		elif [ "$arch" == "aarch64" ]; then
			FILTER=' | grep -ie "aarch64\\|arm64" '
		fi

"$FILTER" is ment to be added in the "$version" variable of the installation script.

I've tested with both

am -e https://github.com/music-assistant/companion music-assistant

that contains "amd64" and

am -e https://github.com/ivan-hc/Anydesk-appimage anydes

that contains "x86_64", and worked

from am.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.