Comments (7)
Can you send me a bit of details? What version of React Native, what version of react-native-video-controls, etc.
from react-native-video-controls.
onLoadStart={ () => {} } // Fired when loading of the source starts
onProgress={ () => {} } // Fired every ~250ms when the video progresses
onError={ () => {} } // Fired when an error is encountered on load
onBack={ () => {} } // Function fired when back button is pressed.
onLoad={ () => {} } // Fired when loading is complete
onEnd={ () => {} } // Fired when the video is complete.
this.events = {
onLoadStart: this.props.onLoadStart || this._onLoadStart.bind( this ),
onProgress: this.props.onProgress || this._onProgress.bind( this ),
onError: this.props.onError || this._onError.bind( this ),
onLoad: this.props.onLoad || this._onLoad.bind( this ),
onEnd: this.props.onEnd || this._onEnd.bind( this ),
onScreenPress: this._onScreenPress.bind( this ),
};
RN0.39.2 android6.0.1 react-native-video-controls 1.1.1
I saw your code.
All custom events will replace the events you wrote
Appear BUG
from react-native-video-controls.
So you're overwriting the onLoad function with a blank function?
from react-native-video-controls.
Yes。
Custom events should not replace the original event。
from react-native-video-controls.
Removed onLoad events from being editable in 1.2.x
from react-native-video-controls.
@kylemilloy I realize I am late to this party but I think that removing the ability to pass an onLoad is not a good idea. Could I get your thoughts on this?
I just started looking at this library after working with react-native-video and need to use the onLoad to be able to get the the width and height of the video that is loaded so I can resize the component to fill the screen width and scale the height based on the aspect ratio. That being said I think it makes sense to not remove the original onLoad event since your component relies on the logic in there.
Based on this I would suggest that your onLoad calls the onLoad passed in with the props with the arguments it receives. (you may want to do this with all of the callback props that were removed) Thoughts?
Id be happy to contribute with a PR based on what we decide.
from react-native-video-controls.
Pull away, my son. Thanks for the help. Yeah that'd work I think. Easy enough to just do something like
// original onLoad
_onLoad() {
// do original stuff
this.props.onLoad();
}
Would probably be good to do some checking to ensure the prop onLoad is a fx
from react-native-video-controls.
Related Issues (20)
- add custom btn and change rate
- How to use react-native-video-controls with typescript? HOT 3
- How do you reset the controlTimeout with custom buttons? HOT 1
- customise controller
- e
- Alternative to this lib HOT 2
- Here I add change color for the loader
- Support Integrate VAST Ads like react-native-video
- What is props.navigator ?
- Replay button when video end is reached HOT 2
- paused prop bug
- Starting on video shows exit full screen button instead full screen button & video doesn't plays on ios
- Play and pause videos in React-Native FlatList HOT 1
- Video player not working on Xcode 14.2
- Poster gets removed in IOS
- Default Loading Animation on Initial Loading HOT 1
- on click of onenterfullscreen not working in ios HOT 3
- Spotify Stops when I open RN app that uses react-native-video-controls lib HOT 1
- i can only hear sound not video HOT 2
- IOS doesn't play sound but works on Android
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native-video-controls.