Giter Club home page Giter Club logo

Comments (6)

mike0sv avatar mike0sv commented on August 27, 2024 1

We only have ".mlem.yaml" inside ".mlem" dir, so we can just rename them ".yaml".
Other model/dataset metafiles are just "mlem.yaml". We can rename them into ".mlem" or "meta.mlem" of course, but not sure if we should.
Another feature we can get: name those files <object_type>.mlem - this way we would know which type of object is there without reading metadata (but this will make checking if dir is mlem object a bit harder)

from mlem.

mike0sv avatar mike0sv commented on August 27, 2024 1
  1. The other ➕ is faster repo scanning for example. I think rn we dont have enought arguments, issues like #37 could add something to the table. For now lets remove this from alpha scope.
  2. Yep, and we can just leave .yaml for now. As for pydantic, yes, if it is possible in jsonschema, and we will try to contribute our polymorphic stuff to pydantic, we should implement this too.

from mlem.

mike0sv avatar mike0sv commented on August 27, 2024

As for jsonschema, there is a big problem: since pydantic does not support polymorphism, the schema it generates lacks this also. And I can't say for sure if it is even possible: we need to create jsonschema definitions for every implementation of each polymorphic hierarchy and somehow configure fields to be "one of the subclasses of type X".

from mlem.

aguschin avatar aguschin commented on August 27, 2024

Another feature we can get: name those files <object_type>.mlem.

On one hand, I would say the bigger ➕ may be for users as those who new to a particular repo can easier understand what is a particular folder: data or model. On the other, I suppose it's common to have those two in specific parent folders which names explain this good enough. Considering this, it's not clear for me, whether this worth the efforts. What do you think?

As for jsonschema, there is a big problem

Got it. So, the only thing we can do here for now is to write some generic rules, like "treat .mlem just as .yaml. Btw, do you think there is a possibility to fix this by contributing to official pydantic repo?

from mlem.

mike0sv avatar mike0sv commented on August 27, 2024

I think I am happy with the way things are right now (after #114 the thought of adding different names for metafiles gives me nightmares). @aguschin WDYT? should we close this?

from mlem.

aguschin avatar aguschin commented on August 27, 2024

Agreed, let's close this!

from mlem.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.