Sklearn missing from dvcorg/cml-py3:latest about example_cml HOT 8 CLOSED

Addressed and closing the issue (see commit here). Please reopen or make a new issue if you have any other trouble!

from example_cml.

Probably is worth correcting the results.txt error in the first cml.yaml code block here: https://github.com/iterative/cml#getting-started

from example_cml.

Ah sorry classically copied cml.yaml from the wrong place:

it should have had the pip install -r ...

from example_cml.

This is the first one:

This is the second:

Also, love your work! DVC ❤️

from example_cml.

Hi @ivyleavedtoadflax, thanks for trying it out! If I follow correctly, the first code block is from the Usage section of the CML project README, and the second is from Getting Started.

The Usage section is intended to demonstrate the simplest possible use case, with some explanation of the big picture. It's not part of the tutorial. Do you think there's anything we could do in the README to make this more clear?

from example_cml.

Hi @andronovhopf thanks for making great stuff🙏! I think I'd be inclined to at least replicate the pip install... in all places otherwise other users could make the same mistake as me and assume that the docker container already contains all the dependencies required for the tutorial. That said, I should probably have read the whole thing first 🙊

from example_cml.

You're right, leaving it out could confuse people about what's in the Docker container. I'm updating the code examples in the README so pip install... is always present.

Glad you pointed it out! :)

from example_cml.

Thanks @andronovhopf

from example_cml.