Comments (6)
Yes, I pulled this change from upstream to Manager. Want to take a stab at this? I am a bit worried that we are all hacking on Envoy config generator right now, and will have many conflicts.
from pilot.
Sure. re: conflicts, we might need to coordinate PR if rebase conflicts become a problem.
from pilot.
So I am working on the config gen as well. And one part of this is using the routing rules to generate tcp proxy blocks.
However as part of this change, I am beginning to think that we need to reorganize the code to even more cleanly separate envoy config generation from the set of preprocessed inputs to the config generator.
In addition, its unclear how one would go about in an optimized fashion, map the route match condition to a listener or virtual host, followed by the route blocks. A similar problem applies to the tcp proxy as well. In this case, it's even more arcane, as the current proto requires the user to specify IP port and subnet mask combo.
I think we might have to revisit the proto spec and change it such that the user can specify the destination service as part of the match condition.
from pilot.
I believe the original issue is partially addressed by #84 which updates resource.go with the new envoy configuration definitions. I think the remaining piece there is to hook things up to the envoy config generation so the existing integration test passes with the latest envoy? @rshriram, were you going to address that in #84 or should I take that up after #84 goes in?
The next piece, which @rshriram is working on, is to hook these config generation up to the route spec which would be a separate issue/PR.
from pilot.
So, the tests are passing finally. I think you can go ahead. May be keep an eye out for the stuff that @ijsnellf 's #87 is doing, when you add in code for the TCP blocks, so that its easier to wire in routing info in the selection process. However, it shouldn't be a blocker.
from pilot.
Envoy TCP config definitions have been added. Closing this issue as the TCP routing work is tracked by #46
from pilot.
Related Issues (20)
- istioctl not defaulting ns to "default" HOT 1
- Sidecar injection with mutating webhooks HOT 4
- Tests :Sidecar injection with mutating webhooks HOT 3
- Istio injection is not working for modified Deployments. HOT 6
- Ingress with host network HOT 1
- Request Headers Route Rule with composite services does not work HOT 1
- handling service registry client errors HOT 3
- Redirecting all ingress http traffic to https HOT 1
- Relational database adapter for Pilot config store HOT 10
- Diego BBS adapter for Pilot platform data HOT 12
- bazel 0.7 - make setup fails with bazel error on macOS HOT 12
- Use readable cluster names in stats HOT 4
- Build fails on Intel for Istioctl(pilot) HOT 14
- destination.labels is ignored in weighted rule HOT 4
- fails to create mixer configs when namespace field is empty
- Compute Envoy config eagerly rather than on-demand HOT 33
- istioctl kube-inject doesn't work when my pod has 2 containers HOT 2
- Add a script to query pilot for proxy configurations HOT 1
- gRPC-web HOT 1
- How to access the external services when istio with sidecar injected. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pilot.