Re-structure directories in this repo about old_auth_repo HOT 10 CLOSED

I'd vote for 1 as

1. It reduces the number of top-level directories (otherwise we'll have one top-level directory for each executable we have, which makes this repo hard to navigate IMO).
2. The main methods in cmd/ folder only do command line parse while the actual logic is implemented in pkg/ dir. This can mostly avoid us to have sub-packages in the cmd/ dir.

from old_auth_repo.

from old_auth_repo.

I am OK with (1) but the pkg/ directory directly conflicts with your reasoning about having "less top-level" directories. If the code is used ONLY by istio_ca, it has no business living outside of that scope. I am not sure what are we gaining by avoiding sub-packages? Also note that each of the executables under the cmd/ directory can have a sub cmd/ directory that implements their cobra commands if required. I don't think this sub package should be outside the directory.

from old_auth_repo.

Just to make it clear here is what I propose:

istio.io/auth/
cmd/
istio_ca/
cmd/
root.go
BUILD
subpkg1
..
BUILD
ca.go
node_agent/
cmd/
root.go
BUILD
app/
main.go
pkg/ /* contains code that is common to both istio_ca and node_agent */
.....

from old_auth_repo.

from old_auth_repo.

I vote for (1) too, it looks to be consistent with mixer, pilot and galley

from old_auth_repo.

from old_auth_repo.

from old_auth_repo.

(1) looks better to me :)

from old_auth_repo.

Fixed by #233, #205, #203, #181.

from old_auth_repo.