Maximum call stack size exceeded about nyc HOT 10 CLOSED

@mysticatea does it crash if you run mocha --require babel-register test.js?

from nyc.

It does not crash.

> mocha --require babel-register test.js

[Function: Foo]


  0 passing (1ms)

from nyc.

Works for me with Node 4.2.1 and 5.0 on OS X, which makes me think this is a Windows issue. Is there anything interesting in the longer stack trace? There's repetition here:

    at requireHook (C:\Users\t-nagashima.AD\Documents\GitHub\sand\node_modules\nyc\index.js:139:7)
    at require.extensions.(anonymous function) (C:\Users\t-nagashima.AD\Documents\GitHub\sand\node_modules\babel-register\lib\node.js:138:7)
    at requireHook (C:\Users\t-nagashima.AD\Documents\GitHub\sand\node_modules\nyc\index.js:139:7)
    at require.extensions.(anonymous function) (C:\Users\t-nagashima.AD\Documents\GitHub\sand\node_modules\babel-register\lib\node.js:138:7)

but then it crashes on String.split?!

    at String.split (native)
    at Object.win32.resolve (path.js:174:46)
    at Object.win32.relative (path.js:259:16)
    at getRelativePath (C:\Users\t-nagashima.AD\Documents\GitHub\sand\node_modules\babel-register\lib\node.js:72:28)
    at shouldIgnore (C:\Users\t-nagashima.AD\Documents\GitHub\sand\node_modules\babel-register\lib\node.js:123:12)
    at require.extensions.(anonymous function) (C:\Users\t-nagashima.AD\Documents\GitHub\sand\node_modules\babel-register\lib\node.js:137:9)

@bcoe do you have access to a Windows box to confirm this on?

from nyc.

    at requireHook (C:\Users\t-nagashima.AD\Documents\GitHub\sand\node_modules\nyc\index.js:139:7)
    at require.extensions.(anonymous function) (C:\Users\t-nagashima.AD\Documents\GitHub\sand\node_modules\babel-register\lib\node.js:138:7)
    at requireHook (C:\Users\t-nagashima.AD\Documents\GitHub\sand\node_modules\nyc\index.js:139:7)
    at require.extensions.(anonymous function) (C:\Users\t-nagashima.AD\Documents\GitHub\sand\node_modules\babel-register\lib\node.js:138:7)

This is a stackoverflow, so there is possibility of clashing in every function call.

• https://github.com/bcoe/nyc/blob/v4.0.1/index.js#L139
• https://github.com/babel/babel/blob/v6.3.2/packages/babel-register/src/node.js#L108

Hmm, Babel seems to call the old extension here, but the old extension is nyc and nyc is calling Babel. So looks there is a potential infinity loop.

filename is C:\Users\t-nagashima.AD\Documents\GitHub\sand\node_modules\mocha\bin\mocha so it's ignored.

from nyc.

@mysticatea could you give the current master branch a shot, there have been some changes to the require-hook that I think might fix the infinite you're seeing.

Disclaimer, I have yet to get subprocess spawning fully functional in Windows.

from nyc.

Ok, I will try it later.

from nyc.

@mysticatea I tested the master branch of nyc on Windows, and it worked great with a couple changes:

1. test.js is ignored by default, so you should change the filename to something like foo.js.
2. nyc currently has trouble capturing exit events in windows, so rather than running mocha I ran the _mocha bin (which does not spawn a subprocess).

nyc --require babel-register node_modules/.bin/_mocha test.js

3. by default the babel register hook will be called for each module in the node_modules folder, you should probably configure babel to ignore this folder.

from nyc.

Thank you for the verification and the information!
I also verified that master branch works.
I'm looking forward to the next release. :)

from nyc.

@mysticatea I've released [email protected] with these fixes for Windows, I've also patched Windows so that it works without needing to reference _mocha:

#87

Your original node_modules/.bin/mocha should work now.

from nyc.

Thank you so much!

from nyc.