test_find_dups_in_dirs gives false negatives on some systems about capidup HOT 2 CLOSED

The problem is caused by a specific visitation order on the files. In fact, it's pure luck that it works on the other systems.

What's happening is that, even after sorting, dup_groups[0] has the 200 g1 files, and dup_groups[1] has the 3 g0 files, while expected_dup_groups[0] is in the reverse order. That is, dup_groups[0] == expected_dup_groups[1] and dup_groups[1] == expected_dup_groups[0]``.

This is due to the way lists are sorted. They are sorted lexicographically, i.e. respective elements are compared one by one until one of them is different (or one list runs out of elements). In most cases so far, by luck and/or system configuration, the first g1 elements in dup_groups have always been alphabetically higher than the first g0 ones. So g0 ends up first.

But in this case, /tmp/pytest-of-capi/pytest-28/test_find_dups_in_dirs_False_02/file140/g1 is visited first on the g1 group, and /tmp/pytest-of-capi/pytest-28/test_find_dups_in_dirs_False_02/file2/g0 is visited first on the g0 group. Since file140 comes alphabetically before file2, g1 is considered lower and sorted first.

The solution is to sort the groups internally before sorting the list of groups.

from capidup.

Had to force push the fixing commit as I forgot to document in the Changelog. Real commit is 37572d5.

from capidup.