Cannot set property 'touchstart' of undefined on Android with modern jQuery about tablednd HOT 6 CLOSED

Perhaps submitting a Pull Request would help speed things along? :) I'm not sure if @isocra is still watching this project but I did manage to get him to merge a PR of mine late last year.

from tablednd.

The problem is that fixHooks was removed. I've opened a ticket here as they want to know how it's being used in the wild. Hopefully they'll have some advice on how to properly do this now:

jquery/jquery#3748

from tablednd.

Hi @cubiclesoft, I've done a test with just removing that hack entirely with jQuery 3. The DnD works fine on an iPad (emulator) and also in-browser.

@isocra, do you recall what this was added for? I suspect perhaps it has a hack to grab pageX and pageY from event but since that time (according to git blame) you've added:

if (e.originalEvent.changedTouches)
            return {
                x: e.originalEvent.changedTouches[0].clientX,
                y: e.originalEvent.changedTouches[0].clientY
            };

and that properly deals with getting the x and y coordinates of the touch.

I'll do up a PR that just removes this hack. Would you mind merging that for me?

from tablednd.

Hi folks,

Sorry, as I'm not using TableDnD at the moment, I don't get much (any) time to fix issues any more. This code was added by a contributor a couple of years ago, in an effort to get touch working better. Looks like it wasn't a good approach.

from tablednd.

@brendon @isocra - Thanks for following up on this.

from tablednd.

Thanks @isocra :) I understand. If you'd like to make me a maintainer on this project I don't mind. I also maintain the acts_as_list rails gem if that helps for credibility.

Yes, it certainly seemed like a bit of a hack :)

from tablednd.