Giter Club home page Giter Club logo

Comments (1)

bmv437 avatar bmv437 commented on June 26, 2024

*Note - This is brain dump for now. I'll try and organize this into a more cohesive explanation later.

This was explored a bit in #24, but in the process of writing up an example I uncovered an issue.
The issue has to do with data scope and questionId references.

Currently data in array items has a merged scope. The arrayItem type uses the <FormSection /> component to scope it's childFields.
data = { ...formData, ...arrayItemData }
This could also be read as
data = { ...globalScope, ...localScope }
or
data = { ...absoluteData, ...relativeData }
where localScope is data that has a prefix from a <FormSection />

The merged scope is passed into condEval() which can cause issues for validation and conditional properties. This is especially true if there is a name collision for a local questionId and a global questionId.

redux-form Field components don't get a merged scope, they only see the localScope.

We need a way to differentiate between questionIds in conditional objects that refer to local scope vs global scope.

The default scope should be local, but we should be able to override that to break out of a local scope and refer to something at the global scope level.

In addition, the mapFieldChildren() utility will always traverse childFields, so it's breaking validation for a section with a questionId to scope it's childFields.

from redux-form-gen.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.