Comments (3)
isaacplmann
commented on August 16, 2024
So you want the last tourAnchor of the same name to overwrite any previous ones?
You could probably get into some weird non-deterministic use cases with that feature. i.e. the last tourAnchor would vary depending on the order components were rendered.
What's the motivation for this feature request?
from ngx-tour.
commented on August 16, 2024
This would actually help with a responsive/adaptive UI also when the browser is resized and element get removed and re-added somewhere else I also get this error.
What is the best way to avoid this error from happening?
Do I have to unregister each anchor in each component when ngOnDestroy is called and so they don't throw errors when added back in again?
from ngx-tour.
isaacplmann
commented on August 16, 2024
The tourAnchor directive automatically unregisters itself in the ngOnDestroy method. You'll only get this error if the ngOnDestroy method of the first anchor happens after the ngOnInit method of the second anchor (with the same anchorId).
@damo1884 making this change would be a breaking change. Want to make a branch and work on this feature?
from ngx-tour.
Related Issues (20)
- Adding maintainers HOT 6
- After update angular 10 I have got a compilation errors. HOT 5
- backdrop not work properly on some tag HOT 1
- show each step after that contents completely render HOT 3
- Move ngxpopper documentation to branch until it's reinstated
- ngx-tour-ng-bootstrap Compilation error HOT 1
- Cannot find module 'ngx-bootstrap'
- Relase ngx-tour-ngx-bootstrap HOT 1
- ERROR in node_modules/ngx-tour-core/lib/tour.service.d.ts(2,13): error TS1005: '=' expected. HOT 4
- Enable HTML tags in step content HOT 1
- enableBackdrop missing in IStepOption? HOT 1
- Overlay doesn't go away on navigating back HOT 1
- Skip a step when the anchorId is undefined HOT 2
- ngx-tour-ngx-popper not intantiating twice in the same module HOT 1
- No provider for TourStepTemplateService! issue while running test with Jest.
- Sriram HOT 2
- All steps render off screen at bottom
- Cannot set properties of undefined (setting 'step')
- Find bug on latest version of lib, cannot go on next step if user not set stepId on IStepOption object
- Overlay not hiding properly
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ngx-tour.