Giter Club home page Giter Club logo

Comments (10)

leppie avatar leppie commented on May 20, 2024 1

af28d19 addresses the error with get-line.

I have changed the topic to reflect the correct issue that is remaining(?).

Also @weinholt saw your loko release 🥇 🎉 . Was wondering what scheme that was from circleci. Thought you had something to do with it, but not a whole native implementation :D

from ironscheme.

weinholt avatar weinholt commented on May 20, 2024 1

The fs-fatfs tests pass now, but only because I don't check that the output is correct. :)

("README.md") 155
#<textual-input-port>
"sspn6hi e itFepile ,63h"
"s"
#<eof>

from ironscheme.

leppie avatar leppie commented on May 20, 2024 1

@weinholt can you try the latest release?

from ironscheme.

weinholt avatar weinholt commented on May 20, 2024 1

@leppie Tested with fs-fatfs; verified that the output is now regular English. Looks good.

from ironscheme.

leppie avatar leppie commented on May 20, 2024

Thanks. Yeah, custom ports are quite badly implemented to keep it compatible with .NET.

The crash issue on the second call was due to not checking for EOF before trying to normalize the EOL chars.

Fixing that, deals with the case where get/set are both supplied, but the other cases are quite broken 🗡

from ironscheme.

weinholt avatar weinholt commented on May 20, 2024

You mean that .NET code is responsible for reading from the ports and they can be passed around to .NET code? Pretty cool if so, but looks difficult. In any other setting I would expect the ports to have their own buffers and no seeking would be needed.

from ironscheme.

leppie avatar leppie commented on May 20, 2024

You mean that .NET code is responsible for reading from the ports and they can be passed around to .NET code? Pretty cool if so, but looks difficult. In any other setting I would expect the ports to have their own buffers and no seeking would be needed.

The idea was to use as much from .NET as possible, but custom ports are a bit of a mess. I could add buffering, but havent really used custom ports, so never had the need.

from ironscheme.

leppie avatar leppie commented on May 20, 2024

This is going to need a proper rework 😿

from ironscheme.

weinholt avatar weinholt commented on May 20, 2024

I didn't check all the cases from the text of the issue though; busy writing USB hub driver code.

from ironscheme.

leppie avatar leppie commented on May 20, 2024

I didn't check all the cases from the text of the issue though; busy writing USB hub driver code.

It's fine. 👍

The issue should be more narrowed down now.

from ironscheme.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.