Comments (11)
eku
commented on August 13, 2024
Thanks for quick response.
If NO_LED_FEEDBACK_CODE is defined, irmp_irsnd_LEDFeedback should not be available, as used in OneProtocol.ino.
Still compile errors
lib/lib_div/IRMP/src/irsndArduinoExt.hpp:70:33: error: 'irmp_irsnd_LedFeedbackPin' was not declared in this scope
irsnd_init(aIrsndOutputPin, irmp_irsnd_LedFeedbackPin, irmp_irsnd_LedFeedbackPinIsActiveLow);
^
lib/lib_div/IRMP/src/irsndArduinoExt.hpp:70:60: error: 'irmp_irsnd_LedFeedbackPinIsActiveLow' was not declared in this scope
irsnd_init(aIrsndOutputPin, irmp_irsnd_LedFeedbackPin, irmp_irsnd_LedFeedbackPinIsActiveLow);
^
lib/lib_div/IRMP/src/irsndArduinoExt.hpp: In function 'void irsnd_on()':
lib/lib_div/IRMP/src/irsndArduinoExt.hpp:109:13: error: 'irmp_irsnd_LedFeedbackEnabled' was not declared in this scope
if (irmp_irsnd_LedFeedbackEnabled)
^
lib/lib_div/IRMP/src/irsndArduinoExt.hpp:112:43: error: 'irmp_irsnd_SetFeedbackLED' was not declared in this scope
irmp_irsnd_SetFeedbackLED(true);
^
lib/lib_div/IRMP/src/irsndArduinoExt.hpp: In function 'void irsnd_off()':
lib/lib_div/IRMP/src/irsndArduinoExt.hpp:140:13: error: 'irmp_irsnd_LedFeedbackEnabled' was not declared in this scope
if (irmp_irsnd_LedFeedbackEnabled)
^
lib/lib_div/IRMP/src/irsndArduinoExt.hpp:143:44: error: 'irmp_irsnd_SetFeedbackLED' was not declared in this scope
irmp_irsnd_SetFeedbackLED(false);
from irmp.
ArminJo
commented on August 13, 2024
Thanks for reporting !!! 🥇
from irmp.
eku
commented on August 13, 2024
Still compile errors, even with 62c8689.
from irmp.
ArminJo
commented on August 13, 2024
You mean this Must not be enabled ?
| USE_ONE_TIMER_FOR_IRMP_AND_IRSND | disabled | Must be defined if you use receiving and sending simultaneously, since both use the same timer resource. Must not be enabled if you only use receiving. |
|---|
from irmp.
eku
commented on August 13, 2024
I use the receiver and sender simultaneously, so I defined USE_ONE_TIMER_FOR_IRMP_AND_IRSND. I hope I got that one right.
Compile errors still come from defining NO_LED_FEEDBACK_CODE.
lib/lib_div/IRMP/src/irsndArduinoExt.hpp: In function 'void irsnd_on()':
lib/lib_div/IRMP/src/irsndArduinoExt.hpp:121:13: error: 'irmp_irsnd_LedFeedbackEnabled' was not declared in this scope
if (irmp_irsnd_LedFeedbackEnabled)
^
lib/lib_div/IRMP/src/irsndArduinoExt.hpp:124:43: error: 'irmp_irsnd_SetFeedbackLED' was not declared in this scope
irmp_irsnd_SetFeedbackLED(true);
^
lib/lib_div/IRMP/src/irsndArduinoExt.hpp: In function 'void irsnd_off()':
lib/lib_div/IRMP/src/irsndArduinoExt.hpp:150:13: error: 'irmp_irsnd_LedFeedbackEnabled' was not declared in this scope
if (irmp_irsnd_LedFeedbackEnabled)
^
lib/lib_div/IRMP/src/irsndArduinoExt.hpp:153:44: error: 'irmp_irsnd_SetFeedbackLED' was not declared in this scope
irmp_irsnd_SetFeedbackLED(false);
from irmp.
ArminJo
commented on August 13, 2024
I amended the last commit, so you must get the sources again.
from irmp.
eku
commented on August 13, 2024
git pull says Bereits aktuell..
from irmp.
ArminJo
commented on August 13, 2024
Sorry sorry! I checked the wrong example.
from irmp.
ArminJo
commented on August 13, 2024
Hi Erik,
can you test it again, before I release the hotfix.
Thanks!
from irmp.
eku
commented on August 13, 2024
Both IRMP and IRSND compile with NO_LED_FEEDBACK_CODE.
I think I have seen potential for optimisation. Possibly make the including of headers dependent on this. But it's up to you.
from irmp.
ArminJo
commented on August 13, 2024
Thanks 👍
Code size optimisations are always welcome 😀
from irmp.
Related Issues (20)
- Bang and Olufsen send frequency seems to be wrong, and send is not working HOT 5
- examples/simpleReceiver HOT 1
- bugs in irmpArduinoExt.cpp.h irmp_print_protocol_name HOT 1
- Arduino simulations for the examples 😀 - feature update HOT 5
- 'Serial' was not declared in this scope (ATTiny) HOT 1
- R repeat displaying even when pressing different buttons in a rapid manner HOT 1
- CANNOT decode RC6 (TATASKY), PANASONIC AC & Ogeneral AC HOT 5
- Additional documentation for DigiSpark boards HOT 2
- Arduino Due compatibility HOT 5
- esp8266 resets in non intrrupt mode HOT 5
- IRTimer.hpp needs small corectoin for __AVR_ATmega4809__ HOT 1
- How use IRMP16 protocol, send and recieve example? HOT 1
- RX Feedback LED wrong polarity HOT 1
- Second IRMP sending crashes on ESP32 with "register interrupt service failed"
- setting IRMP_LOGGING to 1 in irmpconfig.h crashes ESP32 HOT 1
- Attiny1616 support broken (and by implication ATtiny1614 and 1617 as well) HOT 1
- Transmit creates junk (Flipper sees it as RAW) for NEC protocol HOT 2
- boot loop on Wemos Lolin S3 Mini HOT 1
- Compile Fail with ESP32 core 3.x HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from irmp.