regression: parse error related to comment lines about prog8 HOT 7 CLOSED

Ooh... that PR didn't hold too long. I'll amend it with a test for that and look into it.

from prog8.

It popped up immediately because I was doing a p8compile examples/*.p8 after the merge of the PR :-)
No worries, here's a skeleton for the test that I worked on before going for an ice cream:

    @Test
    fun testCommentLinesWorkWithEmptyLines() {
        val srcText = """; comment before empty line

; comment after empty line

main {
    sub start() {
    }
}
"""
        val parseTree = parseModule(srcText)
        assertTrue(parseTree.block().size > 0)
    }

from prog8.

Well, that's the nice thing about automated tests ;)

Anyways, just pushed to #45.

The problem was this:

• comments go into their own channel, and aren't seen by the parser
• EOLs, however are, since they are used as end-of-statement marker etc
• By looking at just the EOL lexer rule, one can get the impression, that the parser will never see consecutive EOLs - it seems they should "eat up" all prior vertical whitespace
• But that's not true, putting comments in between EOLs has the parser see consecutive EOLs (which are separated by the invisible comments)

So the fix itself was straight-forward:

• EOL? -> EOL*
• EOL -> EOL+

from prog8.

Hm, since #45 was already merged the fix didn't appear there. So I just opened #48.

from prog8.

Btw: thanks for checking on me. It's great working with you 👍

from prog8.

fixed by merging #48 .

I appreciate your extensive problem reports and analyses they really help getting to the core of the matter

from prog8.

Thank you :D

from prog8.