Giter Club home page Giter Club logo

Comments (15)

AlexHarker avatar AlexHarker commented on May 22, 2024

This might be the same as the other resizing problem. We can test once I've got the fix in.

from iplug2.

AlexHarker avatar AlexHarker commented on May 22, 2024

I can't recreate this with iPlugEffect (I think I've got the build settings right). Is it bitmap related?

from iplug2.

olilarkin avatar olilarkin commented on May 22, 2024

did you change it to use IGRAPHICS_NANOVG in IPlugEffect-web.mk ?

diff --git a/Examples/IPlugEffect/config/IPlugEffect-web.mk b/Examples/IPlugEffect/config/IPlugEffect-web.mk
index 44912e1111..828d0ae75b 100644
--- a/Examples/IPlugEffect/config/IPlugEffect-web.mk
+++ b/Examples/IPlugEffect/config/IPlugEffect-web.mk
@@ -6,13 +6,13 @@ WAM_SRC += $(IPLUG_EXTRAS_PATH)/MidiSynth.cpp

 # WAM_CFLAGS +=

-WEB_CFLAGS += -DIGRAPHICS_CANVAS
-#WEB_CFLAGS += -DIGRAPHICS_NANOVG -DIGRAPHICS_GL -DIGRAPHICS_GLES2
+#WEB_CFLAGS += -DIGRAPHICS_CANVAS
+WEB_CFLAGS += -DIGRAPHICS_NANOVG -DIGRAPHICS_GL -DIGRAPHICS_GLES2

 WAM_LDFLAGS += -s EXPORT_NAME="'AudioWorkletGlobalScope.WAM.IPlugEffect'" -O2 -s ASSERTIONS=0

-WEB_LDFLAGS += -O2 -s ASSERTIONS=0
+WEB_LDFLAGS += -O2 -s ASSERTIONS=0

 #if you want to use NANOVG/WebGL, you must link with -s USE_GLFW=3 -s USE_WEBGL2=0 -s FULL_ES3=1

-#WEB_LDFLAGS += -s USE_GLFW=3 -s USE_WEBGL2=0 -s FULL_ES3=1
\ No newline at end of file
+WEB_LDFLAGS += -s USE_GLFW=3 -s USE_WEBGL2=0 -s FULL_ES3=1

from iplug2.

AlexHarker avatar AlexHarker commented on May 22, 2024

Yes.

from iplug2.

olilarkin avatar olilarkin commented on May 22, 2024

this is what i get, which is wrong...

resize

from iplug2.

AlexHarker avatar AlexHarker commented on May 22, 2024

weird - I don't see any text on my builds. I will try to double check I am building correctly. Any quick way to check for nanovg?

from iplug2.

olilarkin avatar olilarkin commented on May 22, 2024

check javascript console for "IGraphics NanoVG @ 60 FPS"

from iplug2.

AlexHarker avatar AlexHarker commented on May 22, 2024

screen shot 2018-12-01 at 22 48 04

I get this, but it works correctly - definitely using NanoVG. I'm on the master with no edits, other than the config file.

from iplug2.

olilarkin avatar olilarkin commented on May 22, 2024

on retina screen?

from iplug2.

AlexHarker avatar AlexHarker commented on May 22, 2024

Yep.

from iplug2.

olilarkin avatar olilarkin commented on May 22, 2024

hmmm. those errors are normal

from iplug2.

AlexHarker avatar AlexHarker commented on May 22, 2024

OK. This might be chrome version or OS specific then perhaps?

from iplug2.

AlexHarker avatar AlexHarker commented on May 22, 2024

OK - I realised I was testing the wrong mode. I have now pushed the scaling fix to master which includes some other adjustments for safety of transforms etc. Be good for you to test it at your end, but I'm confident that this should now be correct.

from iplug2.

AlexHarker avatar AlexHarker commented on May 22, 2024

fixed in 899fb26

from iplug2.

olilarkin avatar olilarkin commented on May 22, 2024

confirmed working

from iplug2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.