Giter Club home page Giter Club logo

Comments (8)

daviddias avatar daviddias commented on June 15, 2024 2

This one could be just part of the CR process. Make sure it is always easy to read.

from aegir.

dignifiedquire avatar dignifiedquire commented on June 15, 2024

cc @diasdavid @noffle @nginnever @RichardLitt

from aegir.

RichardLitt avatar RichardLitt commented on June 15, 2024

I think that enforcing max-depth makes sense. Refactoring is easier. Adding it to the ESLint and then having a note about why in the js-contributing.md sounds good to me. Shall I?

from aegir.

dignifiedquire avatar dignifiedquire commented on June 15, 2024

Make sure it is always easy to read.

CR failed so far catching this consistently if I look at some parts of the js-ipfs-* code base, so while that should be a goal I feel we should enforce it using the linter.

Adding it to the ESLint and then having a note about why in the js-contributing.md sounds good to me. Shall I?

If everyone is happy, yes please :)

from aegir.

daviddias avatar daviddias commented on June 15, 2024

What if we make the max being 4, because you know, with 2 spaces tabs, that is just 8 spaces total, not that bad :D

from aegir.

dignifiedquire avatar dignifiedquire commented on June 15, 2024

@diasdavid 4 sounds 👍 to me

from aegir.

daviddias avatar daviddias commented on June 15, 2024

let's do it :)

from aegir.

RichardLitt avatar RichardLitt commented on June 15, 2024

Ahhh Ok! Thanks @dignifiedquire

from aegir.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.