Giter Club home page Giter Club logo

Comments (3)

kevincox avatar kevincox commented on June 17, 2024

After further investigation the copy to clipboard was never working but the error was ignored with a warning. Now it fails the deploy.

from ipfs-deploy.

hacdias avatar hacdias commented on June 17, 2024

@kevincox hmm, that's very odd. Can you try adding the flag -C to see if it fixes it?

After further investigation the copy to clipboard was never working but the error was ignored with a warning. Now it fails the deploy.

Yeah, we were not making use of any errors. I decided that it's best to fail than to hide what's happening. However, this error seems to happen during installation and not runtime so I really don't understand how it is happening now.

However if that behavious is desired there should be a documented way to disable it.

-C. I should add the entire CLI usage on the docs.

I would recomend not copying to the clipboard by default because having your clipboard editied is an unexpected default for a random CLI tool.

I personally also agree with you. The default behavior till v8 was to copy to clipboard and open the browser for you. I already disabled the opening in the web browser because of the same reasons.

I want to keep in mind that this CLI was built to make it very easy for beginners to deploy a website on IPFS so it's arguable whether or not we should disable this kind of features.

Personally, I would disable it by default or remove it entirely. We already print the link to the CLI. In most interactive terminals you can just click on them and access the website. And copying it's not hard either.


Let's just see if that fixes your issue and then see how to proceed.

from ipfs-deploy.

kevincox avatar kevincox commented on June 17, 2024

I was actually misunderstanding the failure. IPFS deploy was not actually crashing, my CI was just failing due to the logging change from stderr to stdout. This issue can probably be closed, although #213 does look a bit nicer anyways so maybe it is still worth merging.

The real problem that was crashing my CI was #215

from ipfs-deploy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.