Comments (4)
daviddias
commented on May 20, 2024
1
The DHT API test suite is small too, it should be way more comprehensive, we will get it ! :)
from interface-js-ipfs-core.
victorb
commented on May 20, 2024
Worth nothing is that the current DHT tests sometimes are not really testing anything. Looking at this file https://github.com/ipfs/interface-ipfs-core/blob/bad70aca3816b98eb88846183af404202a047055/js/src/dht.js, you can see that for example dht.provide test makes a call to provide but doesn't actually read the results, so we're not really sure if it's working or not.
from interface-js-ipfs-core.
alanshaw
commented on May 20, 2024
@vasco-santos has done a bunch of work on this:
- Docs have been updated https://github.com/ipfs/interface-ipfs-core/blob/master/SPEC/DHT.md
- API
findpeerandfindprovsrenamed in camel case (findPeer,findProvs) - Core API is now returning
PeerInfoobjects (HTTP and CLI compatibility is retained) - Tests have been added, updated here and in js-ipfs
Can we consider this done @daviddias?
from interface-js-ipfs-core.
daviddias
commented on May 20, 2024
Sounds good to me!
from interface-js-ipfs-core.
Related Issues (20)
- Link to examples gives a 404 HOT 1
- Consider per-language core-interface repos HOT 13
- Make the size field of ls correspond to to the size of the file HOT 10
- Ensure all arguments to ipfs.add are documented HOT 1
- [Feature] Pin add Import status (as progress callback) HOT 1
- adding unsubscribe(eventName) HOT 3
- Undocumented key.info HOT 2
- Question[Stress testing MFS]: How does `ipfs.files.rm` work? HOT 1
- Add `pin` option to dag.put HOT 1
- The current transaction exceeded its quota limitations.
- Events on peer connect and disconnect HOT 3
- Gateway should return the peerId along with the block in the response HOT 1
- cat function how to get the filename using hash HOT 2
- Convert examples in docs to async/await
- Convert tests to use `async/await`
- An in-range update of aegir is breaking the build 🚨 HOT 3
- How long will files be available for? HOT 1
- globSource missing! HOT 7
- An in-range update of ipfs-utils is breaking the build 🚨 HOT 1
- Files API add example has a bug HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from interface-js-ipfs-core.