Giter Club home page Giter Club logo

Comments (3)

lkyles777 avatar lkyles777 commented on May 27, 2024

@mpeyper I was having a look at this one and playing around in applyMiddleware.js (having no luck). Set up a mini test react app but with the same store as above. Interestingly, it started to apply both middlewares when the order was changed i.e

const store = createStore(reducer, compose(
  applyMiddleware(wormhole('example')),  
  applyMiddleware(thunk)
))

from redux-subspace.

mpeyper avatar mpeyper commented on May 27, 2024

@lkyles1991 it appears as though all applyMiddleware calls are being applied to the root store, but only the first one (because of how compose works) is being applied to subspaces.

Here are some unit tests that highlight the issue:

import { createStore, combineReducers, compose } from 'redux'
import { subspace, applyMiddleware, namespaced } from '../src'

describe('applyMiddleware bug tests', () => {

  const TEST_ACTION = 'TEST_ACTION'

  const testAction = (value) => ({ type: TEST_ACTION, value })

  const childReducer = (state = { value: 'initial value' }, action) => {
    if (action.type === TEST_ACTION) {
      const { type, ...values } = action
      return { ...state, ...values }
    }
    
    return state
  }

  const parentReducer = combineReducers({ child1: childReducer, child2: namespaced('childNamespace')(childReducer) })

  const middleware = (newKey, value) => () => (next) => (action) => {
    if (action.type === TEST_ACTION) {
      return next({ ...action, [newKey]: value })
    }

    return next(action)
  }

  it('should allow multiple applyMiddleware enhances for the root store', () => {
    const parentStore = createStore(parentReducer, compose(
      applyMiddleware(middleware('value2', 'middleware value 1')),
      applyMiddleware(middleware('value3', 'middleware value 2'))
    ))

    parentStore.dispatch(testAction('action value'))

    expect(parentStore.getState()).to.deep.equal({
      child1: {
        value: 'action value',
        value2: 'middleware value 1',
        value3: 'middleware value 2'
      },
      child2: {
        value: 'initial value'
      }
    })
  })

  it('should allow multiple applyMiddleware enhances for subspaces', () => {
    const parentStore = createStore(parentReducer, compose(
      applyMiddleware(middleware('value2', 'middleware value 1')),
      applyMiddleware(middleware('value3', 'middleware value 2'))
    ))

    const childStore = subspace((state) => state.child2, 'childNamespace')(parentStore)

    childStore.dispatch(testAction('action value'))

    expect(parentStore.getState()).to.deep.equal({
      child1: {
        value: 'initial value'
      },
      child2: {
        value: 'action value',
        value2: 'middleware value 1',
        value3: 'middleware value 2'
      }
    })
  })
})

Currently, this test results in:

  applyMiddleware bug tests
    ✓ should allow multiple applyMiddleware enhances for the root store
    1) should allow multiple applyMiddleware enhances for subspaces


  1 passing (46ms)
  1 failing

  1) applyMiddleware bug tests
       should allow multiple applyMiddleware enhances for subspaces:

      AssertionError: expected { Object (child1, child2) } to deeply equal { Object (child1, child2) }
      + expected - actual

         }
         "child2": {
           "value": "action value"
           "value2": "middleware value 1"
      +    "value3": "middleware value 2"
         }
       }

from redux-subspace.

mpeyper avatar mpeyper commented on May 27, 2024

Resolved by #62

from redux-subspace.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.