bug: dismiss callback from useIonModal is not called after first dismiss about ionic-framework HOT 4 OPEN

Thanks for the issue! This issue has been labeled as needs reproduction. This label is added to issues that need a code reproduction.

Please reproduce this issue in an Ionic starter application and provide a way for us to access it (GitHub repo, StackBlitz, etc). Without a reliable code reproduction, it is unlikely we will be able to resolve the issue, leading to it being closed.

If you have already provided a code snippet and are seeing this message, it is likely that the code snippet was not enough for our team to reproduce the issue.

For a guide on how to create a good reproduction, see our Contributing Guide.

from ionic-framework.

Here the github repo https://github.com/mattiaGec/IonicModalTest

from ionic-framework.

from ionic-framework.

Hello @mattiaGec thank you for reporting this issue!

I can confirm the problematic behavior.

When the dismiss callback returned by useIonModal is called multiple times, it only attempts to dismiss the modal the first time it is called.

This is due to the implementation for the dismiss method in useOverlay:

The specific problem is this line of code:

I will classify this as a bug and the team can prioritize it within the backlog. If anyone would like to submit a PR for this, I would gladly welcome the contribution!

This would be the proposed change that I would validate with testing:

const dismiss = useCallback(async (data?: any, role?: string) => {
  if (overlayRef.current) {
    const didDismiss = await overlayRef.current.dismiss(data, role);
    if (didDismiss) {
      overlayRef.current = undefined;
      containerElRef.current = undefined;
    }
  }
}, []);

from ionic-framework.