use of strchrnul and fmemopen blocking Android port about tlsdate HOT 8 CLOSED

Is there a plan to add fmemopen for android's bionic libc such as an open bug? If not, I'd open such a bug and I would also make sure that until that bug is closed, we should ship our own fmemopen or use something else on Android.

On the other have you considered replacing it with open_memstream on Android?

As far as strchrnul goes - I think it is fine to add a few helper functions on a per platform basis. Perhaps we can put such stuff in android/util.c or something similar?

from tlsdate.

The public android issue tracker doesn't have any mention of fmemopen, I'll go ahead and submit a bug requesting it's implementation.

open_memstream is also is not provided on Android. However, it exists in the internal libcutils library, however this lib is not accessible to apps.

Could we import it this proposed android/ dir?

from tlsdate.

I'd suggest you create tlsdate/src/platform/foo.{h,c} and add reasonably licensed code. If you add say, http://gitweb.dragonflybsd.org/dragonfly.git/blob/HEAD:/lib/libc/stdio/fmemopen.c - just grab the entire file and #ifdef it into use for Android. That way, we can easily forward port stuff and also, we won't ever use it except on Android when we satisfy the #ifdef check.

from tlsdate.

I'd like to tag 0.0.7 soon - have you managed to build tlsdate for Android?

If possible, I'd appreciate a patch to the INSTALL file that explains how to build it on Android.

from tlsdate.

I've pushed a build fix to my fork you can review. It compiles with 3 warnings that I need to fix eventually.

As for instructions on how build it, it requires a special CC environment that I'm not quite sure how to integrate properly into tlsdate's autotools setup (my auto* foo is severely lacking).

In the tlsdate-android app I'm building you can see how I compile tlsdate by checking out this Makefile. As you can see there is a great herd of env vars that need to be wrangled into place.

Current Android port status: it builds and executes, however for some reason all hostname resolving in openssl is failing. Using ip addresses works, but of course cert verification fails.

from tlsdate.

@abeluck Please send me a pull request? If it builds on Android, I'm happy to merge it even with the warnings.

If possible, send me a second pull request for the Android port - even if it's just a second Makefile entirely like Makefile.android - we can easily keep it building.

from tlsdate.

@ioerror pull request for the build patches submitted.

Will open a second request for the build scripts.

from tlsdate.

Awesome - I've merged them both.

from tlsdate.