Giter Club home page Giter Club logo

Comments (12)

csswizardry avatar csswizardry commented on August 16, 2024

Seems like a nice idea, yeah :)

from objects.flag.

florianbouvot avatar florianbouvot commented on August 16, 2024

Why not, but you should consider it for other modules like media, box, list-block, list-ui, button, layout ;)

I work on small and medium projects so I don't see the direct benefit. If I need more than three different dimensions (normal, double and half) I will create an extensions like _objects.flag-extension.scss to add specific case. The rest of the time I play with variables :D

from objects.flag.

csswizardry avatar csswizardry commented on August 16, 2024

Yeah, if I add it here, I will add it everywhere :)

from objects.flag.

nenadjelovac avatar nenadjelovac commented on August 16, 2024

Yes, I assumed it would be everywhere (where it makes sense), I just posted the issue on this repo :)

from objects.flag.

florianbouvot avatar florianbouvot commented on August 16, 2024

For my own information, create an extension of an object : is it a viable idea?

from objects.flag.

csswizardry avatar csswizardry commented on August 16, 2024

If we’re providing large and small already, and we can very easily create huge and tiny, and they’ll be feature-switched off, I don’t really see an issue with this :)

from objects.flag.

nenadjelovac avatar nenadjelovac commented on August 16, 2024

@csswizardry superb! Go trello the feature request! :D

from objects.flag.

csswizardry avatar csswizardry commented on August 16, 2024

@nenadjelovac https://trello.com/c/uBBkDjNN/12-add-tiny-and-huge-variants-to-relevant-modules 👍

from objects.flag.

nenadjelovac avatar nenadjelovac commented on August 16, 2024

I didn't know that board was public! Awesome!

from objects.flag.

nenadjelovac avatar nenadjelovac commented on August 16, 2024

@csswizardry one issue though, Trello card is linking to #4 on Trello, not (here) on github :)

As per #4, add feature-switched --tiny and --huge variants to objects that require it.

from objects.flag.

csswizardry avatar csswizardry commented on August 16, 2024

Good spot… that must be an override that Trello make, because I put the correct URL in:

screen shot 2014-07-23 at 15 02 23

from objects.flag.

nenadjelovac avatar nenadjelovac commented on August 16, 2024

Yeah, must be something like that. Like the way you handled it ;)

from objects.flag.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.