remove sed from scripts about wasabi HOT 4 OPEN

i don't understand the premise, in that a simple google search turns up dockerfile+sed a plenty:

https://www.google.com/search?q=dockerfile+sed&oq=dockerfile+sed&aqs=chrome..69i57.2036j0j1&sourceid=chrome&ie=UTF-8

what is the real concern?

i personally do not feel this is a significant concern.

very open to improvements, i just would like to understand the concrete concerns/objectives.

thoughts?

from wasabi.

Just because people are doing it does not mean it is the right thing to do. The concern is docker uses something called aufs which is a write once file system. Have sed in the script will cause docker to generate a new layer and the more layer there is in the docker image the slower it is and the more file system resource it takes. Also having sed means you are not make the image completely immutable which is a bad practice as well.

from wasabi.

@felixgao Mind creating a pull request with proposed changes to the script(s)? As we had discussed, we own these together as Wasabi committers. If you see areas of improvement, you're empowered to work on the updates to the artifacts and propose them as a PR.

from wasabi.

@felixgao do you mind taking a look at https://github.com/intuit/wasabi/pull/78/files#diff-a02022c11f2de6a41f82f8a76f5e0d3cR19 ? It still contains sed in the Dockerfile but much fewer layers around it. Otherwise how should we approach this?

from wasabi.