Comments (4)
i don't understand the premise, in that a simple google search turns up dockerfile+sed a plenty:
what is the real concern?
i personally do not feel this is a significant concern.
very open to improvements, i just would like to understand the concrete concerns/objectives.
thoughts?
from wasabi.
Just because people are doing it does not mean it is the right thing to do. The concern is docker uses something called aufs which is a write once file system. Have sed in the script will cause docker to generate a new layer and the more layer there is in the docker image the slower it is and the more file system resource it takes. Also having sed means you are not make the image completely immutable which is a bad practice as well.
from wasabi.
@felixgao Mind creating a pull request with proposed changes to the script(s)? As we had discussed, we own these together as Wasabi committers. If you see areas of improvement, you're empowered to work on the updates to the artifacts and propose them as a PR.
from wasabi.
@felixgao do you mind taking a look at https://github.com/intuit/wasabi/pull/78/files#diff-a02022c11f2de6a41f82f8a76f5e0d3cR19 ? It still contains sed in the Dockerfile but much fewer layers around it. Otherwise how should we approach this?
from wasabi.
Related Issues (20)
- Schema `wasabi` contains a failed migration to version 006 HOT 2
- API Authorization HOT 1
- MacOS Errors
- What was the criteria used to determine using Mysql for recording impressions and actions
- intermittent 500 errors HOT 1
- Race condition / non-determinism in /api/v1/experiments endpoint
- How can I identify actions within the Assignment Data?
- Readme says "dockerized". Why so many changes on the host machine?
- Emptying Closed Buckets
- Is this repo still supported? HOT 2
- Unrecognized property observed when running
- Replace Cassandra with Dynamodb. HOT 4
- [Questions] Can Wasabi run without Cassandra ? HOT 2
- How do I connect this to my website? HOT 1
- Wasabi performance
- Setup Issues
- Integrating Wasabi and user directories. HOT 1
- getting the debug logs
- Max calculated fee doesn't match actual fee when sending
- Is there any or any plan for helm charts deployment with this project HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wasabi.