Comments (8)
I can't take a shot at this one. By "validate" do you mean prompt the user to acknowledge that the account number in the config is the desired one?
from cloudraider.
Store account number in config... Get account number with aws api call and verify if they match
from cloudraider.
The way I'm thinking about implementing this is to have the user add a property to src/test/resources/config.properties named "aws.targetAccount". In looking at how I would insert the logic to validate the account, I was thinking about creating a base class for the Delegator classes and put the logic in that base class. Ideally, I could refactor a lot of the boilerplate code from the Delegators into that base class. Does that work?
from cloudraider.
Validating the account number on aws credential initialization would be better i believe.
from cloudraider.
Are we limiting this for config driven accounts? What about credentials that are stored in environment variables or aws config files? Not sure the value of account number here? Perhaps "Who am I?" api call to see which account it is?
from cloudraider.
- we can get account number from env variable
- also handle case where account number is not present.. In such a case we disable acc number validation altogether.
from cloudraider.
So my understanding is that you want the user to indicate what account he is targeting via an env var. The code should then validate that the credentials that are being used are actually for that "target" account number. If the env var does not exist, then no validation takes place.
from cloudraider.
Added comments here - https://github.com/intuit/CloudRaider/pull/13/files
So the check priority will be like as follows:
- account number from env variable (doucment the variable name in readme)
- account number in config file
- no account number found in above scenarios, so don't do account number verification (log the same)
from cloudraider.
Related Issues (14)
- Blocking port script fails
- Fix PR build
- Support having multiple config files HOT 1
- Port block scenario fails when run with ssm HOT 1
- Documentation update for first time users HOT 3
- Documentation for Cloud Raider Core Library
- Add Onboarding Guide for First Time Users
- Update the Java Version of the Core Cloud Raider Library HOT 2
- Put all images under common directory and refine directory structure HOT 4
- Automate setup of mock service on AWS and run FMEA suite on that service
- Include test coverage measurement & reporting tools HOT 4
- Explore and Setup CI/CD pipeline to run core library code
- Automate running FMEA test suite using cucumber client HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cloudraider.