Comments (6)
jonathan-taylor
commented on August 14, 2024
Yes, I am aware of how pre-commits work.
I am already running the labs before pushing. This repo is not the place for this.
This is why I've closed this PR.
…________________________________
From: Thomas Schmelzer ***@***.***>
Sent: Tuesday, August 22, 2023 11:17 AM
To: intro-stat-learning/ISLP_labs ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [intro-stat-learning/ISLP_labs] JupyterBook? (Issue #9)
Going forward I would like to make sure that all notebooks are executed once they have been committed. This will add some extra level(s) of robustness. This could be done in the context of a JupyterBook that would iterate over all of them and put them into a book.
—
Reply to this email directly, view it on GitHub<#9>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AACTM27IGX5K4N5BOLPKG2TXWTZTNANCNFSM6AAAAAA32J7IUU>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
from islp_labs.
tschm
commented on August 14, 2024
You mean you run the labs locally before every push? I don't wanna stop you in doing that but to make sure nothing is broken it's a good idea to repeat this step in an automated workflow... My comment above is unrelated to pre-commit
from islp_labs.
jonathan-taylor
commented on August 14, 2024
Thanks. I realize your intention is good. I'm aware it would be good in a workflow but this is not how this is being done.
I do actually have some familiarity with good practices in open source.
…________________________________
From: Thomas Schmelzer ***@***.***>
Sent: Tuesday, August 22, 2023 11:25 AM
To: intro-stat-learning/ISLP_labs ***@***.***>
Cc: Jonathan Taylor ***@***.***>; Comment ***@***.***>
Subject: Re: [intro-stat-learning/ISLP_labs] JupyterBook? (Issue #9)
You mean you run the labs locally before every push? I don't wanna stop you in doing that but to make sure nothing is broken it's a good idea to repeat this step in an automated workflow... My comment above is unrelated to pre-commit
—
Reply to this email directly, view it on GitHub<#9 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AACTM2ZTY6KB56JFO635QH3XWT2S3ANCNFSM6AAAAAA32J7IUU>.
You are receiving this because you commented.Message ID: ***@***.***>
from islp_labs.
tschm
commented on August 14, 2024
You are certainly by far the best academic I came across when it comes to adopting good DevOps practices :-) Of course, you may argue that you test your notebooks already downstream in the development process of ISLP --- the package. And that's good, too. However, I think given you don't have to pay for running those workflows there is no harm to run through them again, in particular that you get a beautiful JupyterBook as a byproduct.
from islp_labs.
tschm
commented on August 14, 2024
Given your personal tastes, you may enjoy browsing through https://github.com/cvxgrp/.github
You would be the 2nd user in the stats department :-)
from islp_labs.
tschm
commented on August 14, 2024
and https://www.cvxgrp.org/cvx_short_course/docs/index.html
from islp_labs.
Related Issues (11)
- Missing output HOT 3
- Bike sharing data example HOT 2
- seed_everything() unavailable in requirements.txt pytorch-lightning version HOT 7
- Contributors HOT 13
- RunTimeErrors HOT 5
- Lab Chapter 04 - standarization done before train/test split HOT 2
- Chapter 5 Conceptual exercise 2h HOT 1
- Typos HOT 3
- Chapter 4 Classification Python Lab corr() numeric_only no longer supported?
- Installation under Python 3.12 fails HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from islp_labs.