missing points in plots for delays are not properly handled about ihr-website HOT 17 CLOSED

@romain-fontugne @Rithvik-padma , the line charts can be cut in PlotlyJs. I went through the docs and found this this property allows to have disconnected graph. this is the final result ,

@anugcodes I guess there is no use in using the connectgaps property as by default it is set to false so that is the reason I did not use it, but anyway thanks for the reply as I have checked again by adding connectgaps but it did not work but I found that the logic code used for setting null values in the data did not work correctly, I have tested it and So I have changed the logic for it and now it works fine.
I don't know how did you get the correct graphs for it as the logic is not working as it should.
Anyways I am making a PR to make these changes.
Thanks for pointing this out!

from ihr-website.

@romain-fontugne Can you please explain this briefly?
also the above link takes me to a page not found.

from ihr-website.

@romain-fontugne Could you please brief about the issue in the description? This issue seems related to IHR-Dashboard.

from ihr-website.

Sometimes we have missing data in our graphs but plotly always connect consecutive points even if there is a few missing points in between.
Here is an example: https://ihr.iijlab.net/ihr/en-us/networks/AS3269?rov_tb=routes

There is a lot of missing points for London between 11:45 and 16:15 but because plotly connects all available datapoints it hides the missing data..

from ihr-website.

@romain-fontugne I would like to work on this, can you assign this to me?

from ihr-website.

go ahead @Rithvik-padma

from ihr-website.

@romain-fontugne The type of graph used for representing data is 'lines' because of which the data is interpolated and because of which the missing data is not visible. Possible ways to fix this problem are by either using the 'markers' type or the 'lines+markers' type
I am sharing pics for the graphs

Markers

Lines+Markers

I just wanted to know whether is this what you wanted to have. If this is not what was intended then can you please give some more insights on it?

Thanks!

from ihr-website.

thanks, I think I prefer when there a line. But I really wished that the line gets cut when there is missing data, but that's maybe not possible with plotly. Or maybe we should create different traces with the same color? (one before the cut and one after) but then I'm afraid that the legend will have duplicated entries

from ihr-website.

@emileaben do you have any preferences between these two graphs?

from ihr-website.

thanks, I think I prefer when there a line. But I really wished that the line gets cut when there is missing data, but that's maybe not possible with plotly. Or maybe we should create different traces with the same color? (one before the cut and one after) but then I'm afraid that the legend will have duplicated entries

Yes, ig there would be duplicate entries in the legend. I did not actually think of this approach, if possible I will work more on it but I think we can make a temporary fix by choosing any of these two graph types.

from ihr-website.

OK, then let's go with the markers only

from ihr-website.

OK, then let's go with the markers only

Great I will make a PR soon!

from ihr-website.

@romain-fontugne @Rithvik-padma , the line charts can be cut in PlotlyJs. I went through the docs and found this

this property allows to have disconnected graph.
this is the final result ,

from ihr-website.

also this is the result without using markers

while using lines only the points in the middle are removed

from ihr-website.

@romain-fontugne @Rithvik-padma , the line charts can be cut in PlotlyJs. I went through the docs and found this this property allows to have disconnected graph. this is the final result ,

@anugcodes I guess there is no use in using the connectgaps property as by default it is set to false so that is the reason I did not use it, but anyway thanks for the reply as I have checked again by adding connectgaps but it did not work but I found that the logic code used for setting null values in the data did not work correctly, I have tested it and So I have changed the logic for it and now it works fine. I don't know how did you get the correct graphs for it as the logic is not working as it should. Anyways I am making a PR to make these changes. Thanks for pointing this out!

Yes you are right, i too had to correct the way the two dates were compared.

so the actual problem was here.

from ihr-website.

thanks guys, great work!

from ihr-website.

fixed by #448

from ihr-website.