Comments (13)
Yes, that's a mess, sorry!
Thanks for working on that.
from ihr-website.
Thanks for pointing out @akib22, sorry from my end as I didn't check on the consistency while adding the file.
PS. Tomar kichu lagle janiyo :)
from ihr-website.
Welcome both of you @romain-fontugne and @Aniket762.
Ami obbossoy janabo tomake :) @Aniket762 do you know Bengali?
from ihr-website.
Welcome both of you @romain-fontugne and @Aniket762.
Ami obbossoy janabo tomake :) @Aniket762 do you know Bengali?
@akib22 Yups, ami bangali, abhi durgapur, west bengal, India te thaki 🙈
from ihr-website.
Welcome both of you @romain-fontugne and @Aniket762.
Ami obbossoy janabo tomake :) @Aniket762 do you know Bengali?@akib22 Yups, ami bangali, abhi durgapur, west bengal, India te thaki 🙈
Great to hear that you are Bangali.
from ihr-website.
In eslint, "Component name "Networks" should always be multi-word" giving this error. For details about this rule vue/multi-word-component-names.
@romain-fontugne any suggestion about this error, what should I follow?
from ihr-website.
Yes, I have seen this for several of our components. Maybe now is a good time to rename all components that have this error.
I don't have a strong opinion about how to fix this and I am not sure about what are the best practices.
One possibility is to rename things like this:
Api: ApiView
Contact: ContactView
Corona: CoronaReport
Countries: CountryReport
Documentation: DocumentationView
Footer: AppFooter
Header: AppHeader
Home: HomeView
Networks: NetworkReport
ROV: ROVReport
Basically everything that ends with 'View' are simple pages and those ending with 'Report' are based on dynamically generated content from the API.
But as I said I am open to suggestions.
from ihr-website.
Thank you, I am going with your suggestions.
Inside src/components/ripe/
directory, initTracemon
, ripestat
, and initLatencymon
functions are uesed. I can't find any defination for those function. I think those are errors. Can you please clarify @romain-fontugne? Also please suggest name for those components.
from ihr-website.
All these functions are defined in libraries that are loaded when needed. For example, initLatencymon is defined here "https://atlas.ripe.net/resource/latencymon/latencymon-widget-main.js". See src/main.js.
I guess we can just ignore these errors.
Let's rename them like this:
BgplayWidget
LatencymonWidget
TracemonWidget
Thanks!
from ihr-website.
Thank you for your clarifications. I ignored those errors and updated those component names. As well as open the #54 for review.
from ihr-website.
Thanks, the code looks a lot better. I merged the pull request, there was two 'test' text in GlobalReport I have removed them otherwise it looked good.
But I don't see the components renaming? have pushed your latest changes?
from ihr-website.
Sorry for the late response.
Actually, I added the component name inside the script tag instead of renaming the filename. Because If I rename the filenames, then there will have a chance to remove others' latest changes.
from ihr-website.
OK, I see. thanks!
from ihr-website.
Related Issues (20)
- Regression in Date-Time Filtering in Global Report post vue.js 3 migration HOT 1
- Regression in Group by alternative keys mechanism in Global Report post vue.js 3 migration HOT 1
- Regression in Severities filtering and its reactivity to the table data visualization in Global Report post vue.js 3 migration HOT 1
- Enhancement for `asnames.txt` file to Capture All ASes Encountered in the Global Report HOT 3
- Feature Request: Enhance Mobile Chart Interaction for Improved User Experience HOT 4
- Twitter logo should be changed HOT 1
- Cookie Feature for GDPR Compliance HOT 22
- Update Installation Tutorial Video for Vue 3.js Compatibility HOT 5
- Create Website Shortcut for IHR HOT 3
- Inconsistent Color Scale Displayed on World Map When Clicking on a Country in Global Report Page HOT 18
- Add World Map for Country Selection in Country Report HOT 2
- website overflow in x direction looks weired. HOT 2
- Add a new setup video HOT 2
- Hover effect on website HOT 1
- Adding World Map for country selection for Network Delays During National Lockdowns HOT 2
- Loading page issue HOT 2
- Search Bar result showing priority HOT 1
- Documentation change HOT 1
- Users connected ASN and other information HOT 26
- Implement Notification System for Network Events HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ihr-website.