Inconsistent Eslint and Prettier rules about ihr-website HOT 13 CLOSED

Yes, that's a mess, sorry!
Thanks for working on that.

from ihr-website.

Thanks for pointing out @akib22, sorry from my end as I didn't check on the consistency while adding the file.

PS. Tomar kichu lagle janiyo :)

from ihr-website.

Welcome both of you @romain-fontugne and @Aniket762.

Ami obbossoy janabo tomake :) @Aniket762 do you know Bengali?

from ihr-website.

Welcome both of you @romain-fontugne and @Aniket762.

Ami obbossoy janabo tomake :) @Aniket762 do you know Bengali?

@akib22 Yups, ami bangali, abhi durgapur, west bengal, India te thaki 🙈

from ihr-website.

Welcome both of you @romain-fontugne and @Aniket762.
Ami obbossoy janabo tomake :) @Aniket762 do you know Bengali?

@akib22 Yups, ami bangali, abhi durgapur, west bengal, India te thaki 🙈

Great to hear that you are Bangali.

from ihr-website.

In eslint, "Component name "Networks" should always be multi-word" giving this error. For details about this rule vue/multi-word-component-names.

@romain-fontugne any suggestion about this error, what should I follow?

from ihr-website.

Yes, I have seen this for several of our components. Maybe now is a good time to rename all components that have this error.
I don't have a strong opinion about how to fix this and I am not sure about what are the best practices.

One possibility is to rename things like this:
Api: ApiView
Contact: ContactView
Corona: CoronaReport
Countries: CountryReport
Documentation: DocumentationView
Footer: AppFooter
Header: AppHeader
Home: HomeView
Networks: NetworkReport
ROV: ROVReport

Basically everything that ends with 'View' are simple pages and those ending with 'Report' are based on dynamically generated content from the API.
But as I said I am open to suggestions.

from ihr-website.

Thank you, I am going with your suggestions.

Inside src/components/ripe/ directory, initTracemon, ripestat, and initLatencymon functions are uesed. I can't find any defination for those function. I think those are errors. Can you please clarify @romain-fontugne? Also please suggest name for those components.

from ihr-website.

All these functions are defined in libraries that are loaded when needed. For example, initLatencymon is defined here "https://atlas.ripe.net/resource/latencymon/latencymon-widget-main.js". See src/main.js.
I guess we can just ignore these errors.

Let's rename them like this:
BgplayWidget
LatencymonWidget
TracemonWidget

Thanks!

from ihr-website.

Thank you for your clarifications. I ignored those errors and updated those component names. As well as open the #54 for review.

from ihr-website.

Thanks, the code looks a lot better. I merged the pull request, there was two 'test' text in GlobalReport I have removed them otherwise it looked good.

But I don't see the components renaming? have pushed your latest changes?

from ihr-website.

Sorry for the late response.
Actually, I added the component name inside the script tag instead of renaming the filename. Because If I rename the filenames, then there will have a chance to remove others' latest changes.

from ihr-website.

OK, I see. thanks!

from ihr-website.