Giter Club home page Giter Club logo

Comments (15)

thisiskaransgit avatar thisiskaransgit commented on September 28, 2024 1

Yes , I'll work on this

from ihr-website.

aryan-surin avatar aryan-surin commented on September 28, 2024

Hey @Aniket762 can I contribute to this issue?

from ihr-website.

Aniket762 avatar Aniket762 commented on September 28, 2024

Hey @Aniket762 can I contribute to this issue?

For sure, do you want me to assign this issue to you? By the way, is there any particular UI that you have thought about?

from ihr-website.

thisiskaransgit avatar thisiskaransgit commented on September 28, 2024

I'll work on this issue
and since you gave the additional context for the UI , I will be making it while keeping the context in mind

The 404 page should have a soothing UI and must be responsive. A fancy yet interesting text that might give the end-user a laugh when they hit the page would make the application a bit interactive.

from ihr-website.

Aniket762 avatar Aniket762 commented on September 28, 2024

I'll work on this issue and since you gave the additional context for the UI , I will be making it while keeping the context in mind

The 404 page should have a soothing UI and must be responsive. A fancy yet interesting text that might give the end-user a laugh when they hit the page would make the application a bit interactive.

Okay, that sounds great :) since we haven't heard back from @aryan-surin as of now. Let's wait for a day, if he doesn't get back I would assign you and you can start working. Till then you may check out #33, a pretty beginner-friendly issue. Let me know your thoughts :)

from ihr-website.

Aniket762 avatar Aniket762 commented on September 28, 2024

I'll work on this issue and since you gave the additional context for the UI , I will be making it while keeping the context in mind

The 404 page should have a soothing UI and must be responsive. A fancy yet interesting text that might give the end-user a laugh when they hit the page would make the application a bit interactive.

Hi, do you still want to work on this?

from ihr-website.

Aniket762 avatar Aniket762 commented on September 28, 2024

Hi @thisiskaransgit, take your time and share a basic wireframe you want to develop, and once we have concluded the layout you can code. In case, you don't want to design you can implement the skeleton which I have given while creating the issue. Let me know, which way you are going? :)

from ihr-website.

thisiskaransgit avatar thisiskaransgit commented on September 28, 2024

1
This is the design that I came up with , If you like it then I can start working on the coding part, or if you have some more suggestion to add to it ,or the design is not up to the mark ,let me know.🤝

from ihr-website.

Aniket762 avatar Aniket762 commented on September 28, 2024

1 This is the design that I came up with , If you like it then I can start working on the coding part, or if you have some more suggestion to add to it ,or the design is not up to the mark ,let me know.🤝

Your design looks great, specially with the button part. But, I would say for now, go with the skeleton I have provided then we can make changes accordingly. You button looks good, so keep it that way round in the skeleton.

image

Make sure to keep it responsive in Desktop, mobile and tab view. Since, the deployment bot is still in process, it will be great if you can send the PR while attaching the screenshots and URLs you have tested

from ihr-website.

thisiskaransgit avatar thisiskaransgit commented on September 28, 2024

I am done with coding part and the page is ready and looks just the same as we discussed
404
It's responsive in Desktop, mobile and tab view.

But I was unable to run it in my local host as I was repeatedly getting the following error
Screenshot 2022-04-25 230023
I have tried it multiple times in every way I could look but the result was same

from ihr-website.

Aniket762 avatar Aniket762 commented on September 28, 2024

I am done with coding part and the page is ready and looks just the same as we discussed 404 It's responsive in Desktop, mobile and tab view.

But I was unable to run it in my local host as I was repeatedly getting the following error Screenshot 2022-04-25 230023 I have tried it multiple times in every way I could look but the result was same

Hey @thisiskaransgit, thanks a lot for coding the wireframe, it looks great to me ✨

I am extremely sorry to know that, you were not able to run the code on your localhost. After reading your error I immediately did a dry run on my system, and it ran without any error. There are some things that you can try out to fix this error:

  1. Install the LTS versions of Vue-CLI and Node
  2. Try removing the node modules directory and do a clean install withnpm ci command.

Please let me know if you face any problems in the process! We would try to resolve your error together :)

from ihr-website.

thisiskaransgit avatar thisiskaransgit commented on September 28, 2024

Hey @Aniket762
I have successfully tested it locally with several URL and it's working just as we wanted

  1. Whenever the user requests a invalid URL our custom 404 page appears
  2. redirect button takes us to the home page
  3. The design is same as we discussed

The only issue is that the page is not getting responsive for mobile and tablet view as it's not taking effect on a single page
and was implementing changes throughout the app which were giving error so I didn't applied them.

So should I send the PR ?

from ihr-website.

Aniket762 avatar Aniket762 commented on September 28, 2024

Hey @Aniket762 I have successfully tested it locally with several URL and it's working just as we wanted

  1. Whenever the user requests a invalid URL our custom 404 page appears
  2. redirect button takes us to the home page
  3. The design is same as we discussed

The only issue is that the page is not getting responsive for mobile and tablet view as it's not taking effect on a single page and was implementing changes throughout the app which were giving error so I didn't applied them.

So should I send the PR ?

That's great @thisiskaransgit, send a draft PR. I would like to see the code you have written and also check if the Netlify bot is working fine or not.

I don't know, what is the exact problem you are facing with CSS maybe it is because the global CSS somehow is affecting your CSS and vis-a-vis. To be honest, making it responsive is very important as the world is shifting towards a mobile-first approach. Maybe we can drop some styling elements and only keep the 404 stuff and the redirect button.

To attach the screenshot of how it is looking on the Laptop, mobile, and tablet as of now. Not sure if the bot is working or not :)

Also, thanks a lot for your efforts, means a lot to us! ✨

from ihr-website.

thisiskaransgit avatar thisiskaransgit commented on September 28, 2024

Thanks @Aniket762 for the approval , It's really for me exciting as it's my first Successful PR. I would like to continue to contribute to this project more as it's in my field of interest , so can you guide and share some resources me which can help me to get to know more about this project.
Thank You

from ihr-website.

Aniket762 avatar Aniket762 commented on September 28, 2024

Thanks @Aniket762 for the approval , It's really for me exciting as it's my first Successful PR. I would like to continue to contribute to this project more as it's in my field of interest , so can you guide and share some resources me which can help me to get to know more about this project. Thank You

Thanks, @thisiskaransgit for your kind words. You can join our slack which we are opening up for contributors. Please click here to join the slack.

Although, I reverted back the PR, I guess it broke the prod. I would check it and merge it again. In the meantime, you join slack get onboarded and let's meet soon. What say?

from ihr-website.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.