Giter Club home page Giter Club logo

Comments (5)

tmberthold avatar tmberthold commented on July 3, 2024

Would imply the following constellation for Messaging-Services (see linked PR):

  • bump infomodel-serializer from 4.2.8 to 5.0.3
  • bump java from 4.2.7 to 5.0.3
  • bump interaction from 4.2.7 to 5.0.3

From experience, there will also be breaking changes for the DSC and not just for the Messaging-Services itself, which will have to be tested and adressed in the run-up to the PR. So even if the PR in the Messaging-Services itself can be merged successfully, there could still be breaking conflicts in the DSC, which need to be evaluated beforehand before merging the linked PR.

from ids-messaging-services.

tmberthold avatar tmberthold commented on July 3, 2024

There are two main breaking changes compared to the DSC:

  1. enum classes became interfaces with constants
  2. the newly introduced UriOrModelClass

from ids-messaging-services.

SebastianOpriel avatar SebastianOpriel commented on July 3, 2024

@rmsoyta could you provide some more feedback on requirements from your side? Maybe we could find a version which does not lead to incompabilities but would satisfy your requirements.

from ids-messaging-services.

timwirtz86 avatar timwirtz86 commented on July 3, 2024

A short comment on that. Up to my current understanding, the breaking changes will be caused by the evolution of the version of the java classes (@tmberthold , @SebastianOpriel )? I think so because the serializer should be independent of the info model version used. It is included as test-dependency only and is (sadly) the sole target we test the serializer against. The changes in the interaction library (compared to the latest previous version) are marginal in the sense that we only updated the dependencies.

You could give it a trial and solely include the update of the serializer. This shouldn't cause breaking changes.

from ids-messaging-services.

tmberthold avatar tmberthold commented on July 3, 2024

We have updated the serializer in the DSC as a test, but the e2e-tests of the DSC fail, so changes are hiding here as well.
History of the failed test:
https://github.com/International-Data-Spaces-Association/DataspaceConnector/actions/runs/3629932830/jobs/6123853530

from ids-messaging-services.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.