Comments (7)
nurazem
commented on June 27, 2024
@josler Can you have a look at this? The response is indeed not a valid JSON.
from intercom-php.
dehora
commented on June 27, 2024
Thanks @frankmichel. @nurazem @josler Ideally the server shouldn't return a whitespace artifact, but because the events resource doesn't return JSON the client shouldn't be looking for any on a 2xx response. Looks like the client will need a patch, marking as a bug.
from intercom-php.
nurazem
commented on June 27, 2024
Hi @dehora. I have looked into the issue and I think that the problem is on the server side. Although, the resource doesn't return JSON, the response's Content-Type header is set to 'application/json'. As you can see below Guzzle is trying to parse the body based on that header.
In Guzzle/Service/Command/DefaultResponseParser.php
public function parse(CommandInterface $command)
{
$response = $command->getRequest()->getResponse();
// Account for hard coded content-type values specified in service descriptions
if ($contentType = $command['command.expects']) {
$response->setHeader('Content-Type', $contentType);
} else {
$contentType = (string) $response->getHeader('Content-Type');
}
return $this->handleParsing($command, $response, $contentType);
}
protected function handleParsing(CommandInterface $command, Response $response, $contentType)
{
$result = $response;
if ($result->getBody()) {
if (stripos($contentType, 'json') !== false) {
$result = $result->json();
} elseif (stripos($contentType, 'xml') !== false) {
$result = $result->xml();
}
}
return $result;
}from intercom-php.
aaronfessler
commented on June 27, 2024
I am experiencing this bug as well.
from intercom-php.
webeng
commented on June 27, 2024
Yep, me too.
from intercom-php.
aaronfessler
commented on June 27, 2024
Hey @josler @nurazem what's the ETA on fixing this? It is pretty easy to repeat and is a showstopper:
use Intercom\IntercomBasicAuthClient;
$intercom = IntercomBasicAuthClient::factory(array(
'app_id' => "XXXX",
'api_key' => "YYYY"
));
$intercom->createEvent(array('user_id' => 1, 'created_at'=> time(),'event_name' => 'Code is bogus!'))
Yields this:
Fatal error: Uncaught exception 'Guzzle\Common\Exception\RuntimeException' with message 'Unable to parse response body into JSON: 4' in /Users/aaron/Sites/twine/lib/vendor/guzzle/guzzle/src/Guzzle/Http/Message/Response.php:861
Stack trace:
#0 /Users/aaron/Sites/twine/lib/vendor/guzzle/guzzle/src/Guzzle/Service/Command/DefaultResponseParser.php(47): Guzzle\Http\Message\Response->json()
#1 /Users/aaron/Sites/twine/lib/vendor/guzzle/guzzle/src/Guzzle/Service/Command/OperationResponseParser.php(80): Guzzle\Service\Command\DefaultResponseParser->handleParsing(Object(Guzzle\Service\Command\OperationCommand), Object(Guzzle\Http\Message\Response), 'application/jso...')
#2 /Users/aaron/Sites/twine/lib/vendor/guzzle/guzzle/src/Guzzle/Service/Command/DefaultResponseParser.php(39): Guzzle\Service\Command\OperationResponseParser->handleParsing(Object(Guzzle\Service\Command\OperationCommand), Object(Guzzle\Http\Message\Response), 'application/jso...')
#3 /Users/aaron/Sites/twine/lib/vendor/guzzle/guzzle/src/Guzzle/Service/Command/Opera in /Users/aaron/Sites/twine/lib/vendor/guzzle/guzzle/src/Guzzle/Http/Message/Response.php on line 861
Guzzle 4.2.3
Intercom 1.0.0-b3
from intercom-php.
josler
commented on June 27, 2024
Fixed with v1.0.0-b4!
Thanks.
from intercom-php.
Related Issues (20)
- Contacts Resource - Missing Tag Functionality
- 404 on deprecated endpoints
- [Feature] Documentation
- Laravel 8 requires Guzzle 7.0.1 HOT 5
- Can not install intercom/intercom-php in laravel 8 HOT 4
- API Should not return 404 on input error
- [Help Center] Article order missing
- Support for passing sort on nextSearch
- Code Climate badge
- Missing "List attached companies" endpoint
- User/lead initiated conversation using email returns 400 bad request
- Exceptions does not provide exception body HOT 2
- could not able to create contact using php api HOT 2
- Attach a tag to a contact HOT 1
- Detach a contact from specific tags HOT 1
- Fetch conversation's by lead email?
- Autoload the vendor folder from a subfolder
- Manage Conversation API Missing HOT 1
- Missing Message Factory because of latest php-http/message version HOT 3
- Problem installing package with PHP 8.2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from intercom-php.